Re: [quicwg/base-drafts] editorial: This sentence was hard to parse for me (recovery) (#3383)
Dmitri Tikhonov <notifications@github.com> Wed, 22 January 2020 17:05 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6B3CA1201C6 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jan 2020 09:05:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.896
X-Spam-Level:
X-Spam-Status: No, score=-3.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ncEgQ89bzZA5 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jan 2020 09:05:31 -0800 (PST)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BBAE612018B for <quic-issues@ietf.org>; Wed, 22 Jan 2020 09:05:31 -0800 (PST)
Date: Wed, 22 Jan 2020 09:05:30 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579712730; bh=sXXI9q19Zw1haqu613Y3nwl3OlK/2grpkt8toovkr/o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=xlTP8O1bxZ8URVazj6CAzgDB7K03uH38JY3nnj3ckwD/Ow2zcaJNojBr7Zq/lURmt pRPgCeI/UtR/EvVrXx1/gtoVUAr5J8Tg6l2ODMM90POL+Fl/eDYErq7VLakmRDq3Cp MSBrRmMWI09hBGLb5wRjxwHCDtlRbKdnZHFSL7oc=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5DFMSAKKBAK3CPM454GWZVVEVBNHHCCABNRQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3383/review/346753717@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3383@github.com>
References: <quicwg/base-drafts/pull/3383@github.com>
Subject: Re: [quicwg/base-drafts] editorial: This sentence was hard to parse for me (recovery) (#3383)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e2880da159eb_e853fd76b0cd960521d8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/IdesvQyDmpXs31YP4ZacSXaCPkA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jan 2020 17:05:33 -0000
dtikhonov commented on this pull request. > @@ -272,9 +272,10 @@ SHOULD NOT be used to update RTT estimates if it does not newly acknowledge the largest acknowledged packet. An RTT sample MUST NOT be generated on receiving an ACK frame that does not -newly acknowledge at least one ack-eliciting packet. A peer does not send an -ACK frame on receiving only non-ack-eliciting packets, so an ACK frame that is -subsequently sent can include an arbitrarily large Ack Delay field. Ignoring +newly acknowledge at least one ack-eliciting packet. A peer does usally not s/usally/usually/ Also, I'd place "usually" before does: > A peer usually does not send [...] -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3383#pullrequestreview-346753717
- [quicwg/base-drafts] editorial: This sentence was… mirjak
- Re: [quicwg/base-drafts] editorial: This sentence… Dmitri Tikhonov
- Re: [quicwg/base-drafts] editorial: This sentence… Mike Bishop
- Re: [quicwg/base-drafts] editorial: This sentence… mirjak
- Re: [quicwg/base-drafts] editorial: This sentence… mirjak
- Re: [quicwg/base-drafts] editorial: This sentence… mirjak
- Re: [quicwg/base-drafts] editorial: This sentence… Martin Thomson
- Re: [quicwg/base-drafts] editorial: This sentence… Jana Iyengar
- Re: [quicwg/base-drafts] editorial: This sentence… mirjak
- Re: [quicwg/base-drafts] editorial: This sentence… mirjak
- Re: [quicwg/base-drafts] editorial: This sentence… Mike Bishop
- Re: [quicwg/base-drafts] editorial: This sentence… Jana Iyengar