Re: [quicwg/base-drafts] Move GOAWAY from transport to HTTP (#697)
Mike Bishop <notifications@github.com> Mon, 31 July 2017 04:51 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 23ACC124C27 for <quic-issues@ietfa.amsl.com>; Sun, 30 Jul 2017 21:51:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.799
X-Spam-Level:
X-Spam-Status: No, score=-9.799 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FNpGoAxTnBDm for <quic-issues@ietfa.amsl.com>; Sun, 30 Jul 2017 21:51:28 -0700 (PDT)
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2-ext3.iad.github.net [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 70F22124234 for <quic-issues@ietf.org>; Sun, 30 Jul 2017 21:51:28 -0700 (PDT)
Date: Sun, 30 Jul 2017 21:51:27 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1501476687; bh=vFE/TRiHNeJSK3rkh5qZfHOLginu4yXt3u0bnV0T3Zs=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LTvqVH40TGSZHPVZM0PXnyZM21l9Qqblm5/T5jSBB4c+VcN7dBJsQ74BU9BsJSUNy AGW6DxiweY7vUTfWoSjB6FY47A3jx7DzBUE4lln5eKoL1WRNpaw3ozF6yy8FJd8Tgb PAn8AFiM87wZTONtEpJazCG1wMsy76PwLcCbiaHI=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abbc5f92876995a8ff25d5a900f115602c95d8f52f92cf000000011596794f92a169ce0ea70488@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/697/review/53126539@github.com>
In-Reply-To: <quicwg/base-drafts/pull/697@github.com>
References: <quicwg/base-drafts/pull/697@github.com>
Subject: Re: [quicwg/base-drafts] Move GOAWAY from transport to HTTP (#697)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_597eb74fc6f81_11ff33feec373dc2c765f7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Ifnd7O6YnB55vrometCKL1KevMI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jul 2017 04:51:30 -0000
MikeBishop commented on this pull request. > +higher than the included last stream identifier. Clients MUST NOT send new +requests on the connection after receiving GOAWAY, although requests might +already be in transit. A new connection can be established for new requests. + +If the client has sent requests on streams with a higher stream identifier than +indicated in the GOAWAY frame, those requests were not and will not be +processed. Servers SHOULD reset new streams above this ID with the error code +HTTP_REQUEST_CANCELLED. Servers MAY also reset streams below the indicated ID +with HTTP_REQUEST_CANCELLED if the associated requests were not processed. + +The client can treat these requests as though they had never been sent at all, +thereby allowing them to be retried later on a new connection. Automatically +retrying other requests is not possible, unless this is otherwise permitted +(e.g. idempotent actions like GET, PUT, or DELETE). Requests on stream IDs less +than or equals to the stream ID in the GOAWAY frame remain open until they are +completed successfully, reset, or the connection terminates. I think the sentence itself is worth emphasizing rather than dropping, but I agree that it's a little awkward to say that the request "remains open," since that sounds more like the stream this text refers to in 7540. Hopefully a more appropriate phrase for a request will occur to me when it's not half past bedtime. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/697#discussion_r130272071
- [quicwg/base-drafts] Move GOAWAY from transport t… Mike Bishop
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Mike Bishop
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Martin Thomson
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Mike Bishop
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Mike Bishop
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Martin Thomson
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Mike Bishop
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Mike Bishop
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Mike Bishop
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Martin Thomson
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Mike Bishop
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Mike Bishop
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Martin Thomson
- Re: [quicwg/base-drafts] Move GOAWAY from transpo… Mike Bishop