Re: [quicwg/base-drafts] Path validation is not return reachability (#4068)

Eric Kinnear <notifications@github.com> Wed, 02 September 2020 02:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8ECFB3A09E9 for <quic-issues@ietfa.amsl.com>; Tue, 1 Sep 2020 19:04:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JlWb7lRv6-qV for <quic-issues@ietfa.amsl.com>; Tue, 1 Sep 2020 19:04:35 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BEE143A09DA for <quic-issues@ietf.org>; Tue, 1 Sep 2020 19:04:35 -0700 (PDT)
Received: from github-lowworker-1ac52d7.ash1-iad.github.net (github-lowworker-1ac52d7.ash1-iad.github.net [10.56.25.52]) by smtp.github.com (Postfix) with ESMTP id 1C179E0760 for <quic-issues@ietf.org>; Tue, 1 Sep 2020 19:04:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1599012275; bh=R6fothei8AYlLIvY6xz6aCnx4TA/YOeNhFEyZaqlNUw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TGNxV6FxF3a+4+t/bTQhAgb3/qlAzxem+wmnN8Ll+NDa35eNb8emtU39UvTGv/WvH BXogZfs3TROWs+pHxkBiR5SFd0zlOzC/PiPlSchxMAO42z1QVjt7/BvTfi5aFM0j1F /u+//cAkkFVEAKQsU5bHvHBQqRR/+8jthchM9MHE=
Date: Tue, 01 Sep 2020 19:04:35 -0700
From: Eric Kinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5SIWVXN577R55LPTF5LLPLHEVBNHHCSKUAJI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4068/review/480332361@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4068@github.com>
References: <quicwg/base-drafts/pull/4068@github.com>
Subject: Re: [quicwg/base-drafts] Path validation is not return reachability (#4068)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f4efdb3b9f8_697c1964205341"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Ih7OITp8Xvkv4HhKSb54qKh6Xqg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Sep 2020 02:04:38 -0000

@ekinnear approved this pull request.

Thanks for writing this up, tiny wording suggestions, but looking great! 

> @@ -2134,10 +2134,12 @@ In path validation, endpoints test reachability between a specific local address
 and a specific peer address, where an address is the two-tuple of IP address and
 port.
 
-Path validation tests that packets can be both sent to (PATH_CHALLENGE) and
-received from (PATH_RESPONSE) a peer on the path.  Importantly, it validates
-that the packets received from the migrating endpoint do not carry a spoofed
-source address.
+Path validation tests that packets that are sent to a peer on a path are
+received by the peer. Path validation is used to ensure that packets received
+from a migrating peer do not carry a spoofed source address.
+
+Path validation does not validate that a peer can send in the return direction.
+Peers perform independent validation of a path.

```suggestion
The peer performs independent validation of the return path.
```

> +Path validation tests that packets that are sent to a peer on a path are
+received by the peer. Path validation is used to ensure that packets received

```suggestion
Path validation tests that packets sent on a path to a peer are
received by that peer. Path validation is used to ensure that packets received
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4068#pullrequestreview-480332361