Re: [quicwg/base-drafts] [qpack] Add comment explaining static table (#3576)

Kazu Yamamoto <notifications@github.com> Wed, 15 April 2020 00:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 02B823A1387 for <quic-issues@ietfa.amsl.com>; Tue, 14 Apr 2020 17:37:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.721
X-Spam-Level:
X-Spam-Status: No, score=-1.721 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id soQZqnqQRu70 for <quic-issues@ietfa.amsl.com>; Tue, 14 Apr 2020 17:37:36 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B919C3A1383 for <quic-issues@ietf.org>; Tue, 14 Apr 2020 17:37:36 -0700 (PDT)
Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id CFBE02C0AC8 for <quic-issues@ietf.org>; Tue, 14 Apr 2020 17:37:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586911055; bh=C6BFEV/REx9qnmNWCrFDQ8M8hFthTKshfkRxSeYlSs0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Q8Wp/2/qILaO/Jv0DY4AkDUoHgz9xCUwvmx9nZFoS309aIJ6Xw442/3QjOXyVDuI3 Y+9xuxn4yH+TeCfl2eMc+eRqVuFzjjN35mSc3chAZBpVTD4pDrfL/CTOmniocFDDsG pfAaNghtjP8xSy1pWlV5AoM/q0/7bTru4T19U6EY=
Date: Tue, 14 Apr 2020 17:37:35 -0700
From: Kazu Yamamoto <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4WI5SGKZCPUS3NKYF4UI4E7EVBNHHCHNULTU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3576/review/393384517@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3576@github.com>
References: <quicwg/base-drafts/pull/3576@github.com>
Subject: Re: [quicwg/base-drafts] [qpack] Add comment explaining static table (#3576)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e96574fc07d4_41b43fea838cd964124473"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazu-yamamoto
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Ij7wsZyWO8CsiEyxMffU7Sw_fvM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2020 00:37:40 -0000

@kazu-yamamoto commented on this pull request.



> +this methodology, some of the entries may be inconsistent.  Notably,
+"content-type: text/plain; charset=utf-8" appears twice with two different
+whitespace encodings (entries 52 and 54).

I would like to support @martinthomson because `text/plain; charsert=utf-8-` does not appear *twice*. The other is `text/html`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3576#discussion_r408514594