IETF Logo Mail Archive

Re: [quicwg/base-drafts] ack-eliciting not ACK-eliciting (#3069)

Jana Iyengar <notifications@github.com> Fri, 04 October 2019 00:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2D8D81208CB for <quic-issues@ietfa.amsl.com>; Thu, 3 Oct 2019 17:12:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h4rC3s-lww_6 for <quic-issues@ietfa.amsl.com>; Thu, 3 Oct 2019 17:12:24 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EBBD51208A2 for <quic-issues@ietf.org>; Thu, 3 Oct 2019 17:12:23 -0700 (PDT)
Date: Thu, 03 Oct 2019 17:12:23 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570147943; bh=xSf9o9q6Vr2xKGjCA9umITwSaG5+rYrFayas896260U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=C7nfZ5mrenpS88+CZdagDnZbe0Px03oMcAu44yhKB8TeHPEP6jYsUkEPDu+/8wyjn SobBS7WfXRtEefXh9LgUUBuMwzEnKH2nBL/UC/fx3xbS84jkbdiS4PXGi7JFU2gHCa k4poOL6zQe8EoxUwT0IwUsFxN2GfgW+pzOqoLVxU=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3V24EIU7S6YXSJUX53UPHPPEVBNHHB3NCBX4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3069/review/297213345@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3069@github.com>
References: <quicwg/base-drafts/pull/3069@github.com>
Subject: Re: [quicwg/base-drafts] ack-eliciting not ACK-eliciting (#3069)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d968e673987d_2b1c3fe83eccd95c459e3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Ivjxlxxouit_aFPbQbWlHDLVLd0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Oct 2019 00:12:32 -0000

janaiyengar commented on this pull request.

Sorry, that sentence seems to suggest that ack-eliciting packets have something to do with max ack delay. I've rephrased again.

> @@ -190,6 +190,12 @@ QUIC packet:
 : A complete processable unit of QUIC that can be encapsulated in a UDP
   datagram.  Multiple QUIC packets can be encapsulated in a single UDP datagram.
 
+Ack-eliciting Packet:
+
+: A QUIC packet that contains frames other than ACK and PADDING. These cause a
+  recipient to send an acknowledgment within its maximum ACK delay

```suggestion
  recipient to send an acknowledgment (see {{sending-acknowledgements}}).
```

> @@ -190,6 +190,12 @@ QUIC packet:
 : A complete processable unit of QUIC that can be encapsulated in a UDP
   datagram.  Multiple QUIC packets can be encapsulated in a single UDP datagram.
 
+Ack-eliciting Packet:
+
+: A QUIC packet that contains frames other than ACK and PADDING. These cause a
+  recipient to send an acknowledgment within its maximum ACK delay
+  ({{transport-parameter-definitions}}).

```suggestion
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3069#pullrequestreview-297213345

v2.23.0 | Report a Bug | By Email