Re: [quicwg/base-drafts] Limit CWND increase in slow start (#3232)
Vidhi Goel <notifications@github.com> Mon, 18 November 2019 10:07 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D6A1F120851 for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 02:07:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D4u21-J5j0bX for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 02:07:20 -0800 (PST)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5BCB5120018 for <quic-issues@ietf.org>; Mon, 18 Nov 2019 02:07:20 -0800 (PST)
Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id AE94252060D for <quic-issues@ietf.org>; Mon, 18 Nov 2019 02:07:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574071639; bh=4r/F1CVy6Su/eYdrqV/x2asYQXbb9vjkZKtb2f0vEd4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=2gceDQ9DmVCq90okMFRzC++alIfvv6miY0etBveKoHzM5qBH2NQcqmoRL2bhwigwY CMEAJ93ojOeVVgmEpKfQL/UYfEVwGbWjTRzA061iDrxMLnC3FaCyXdv1Dklxc5hnPI ap8v7a1PdEPsj22j5GTxXTxOBrgr84a9vUC/cBtU=
Date: Mon, 18 Nov 2019 02:07:19 -0800
From: Vidhi Goel <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK53SJBEQHSF333NFNF336P5PEVBNHHB6GTRAA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3232/review/318217275@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3232@github.com>
References: <quicwg/base-drafts/pull/3232@github.com>
Subject: Re: [quicwg/base-drafts] Limit CWND increase in slow start (#3232)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd26d579fa5a_7d1a3fac148cd96c3699c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: goelvidhi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Iz1-qIzudI1_69m1lbjwKUcvUF0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Nov 2019 10:07:22 -0000
goelvidhi commented on this pull request. > @@ -1368,7 +1377,15 @@ acked_packet from sent_packets. return if (congestion_window < ssthresh): // Slow start. - congestion_window += acked_packet.size + if (pacing): + congestion_window += acked_packet.size + else: + // If pacing is not used, limit the increase to + // 2*max_datagram_size per ACK as described in + // {{?RFC3465}} + if (cwnd_increase < 2 * max_datagram_size): + cwnd_increase += bytes_acked + congestion_window += bytes_acked My bad. I would have to fix this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3232#discussion_r347291704
- [quicwg/base-drafts] Limit CWND increase in slow … Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Martin Thomson
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel