Re: [quicwg/base-drafts] Remove handshake confirmed test for KeyUpdte (#3212)

Nick Banks <notifications@github.com> Mon, 11 November 2019 01:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 78CE51200A4 for <quic-issues@ietfa.amsl.com>; Sun, 10 Nov 2019 17:50:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NUyWloj28YVn for <quic-issues@ietfa.amsl.com>; Sun, 10 Nov 2019 17:50:34 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 00277120047 for <quic-issues@ietf.org>; Sun, 10 Nov 2019 17:50:33 -0800 (PST)
Date: Sun, 10 Nov 2019 17:50:33 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573437033; bh=3z93LwNNXfqq8mdYcgGfdl7D0j2vo6qJF3CBpAQxZjY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=xUJcZvZbSxUGOTZQkmWJ1Desx0QQxJXGsYggWQ0XIb9/8UKyQ6/HZq2LgA3YJWmZf 5IUd6sBtjp2tIFZFt+fHAHsfcwDmI0Y81q7QeF25gKRMSPC8OYExZIGwK1Lekkn5Wh pi0cRqrnjC6O7PU7sHBQU722LpuV2w6Rhm6s1nHE=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZJPBB7BCLV7UGLXAV32XYOTEVBNHHB6CGIZA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3212/552262080@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3212@github.com>
References: <quicwg/base-drafts/issues/3212@github.com>
Subject: Re: [quicwg/base-drafts] Remove handshake confirmed test for KeyUpdte (#3212)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc8be693a1e5_18233f8dc6acd96812256b6"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/J2_q17PXbfwboWS0LT_ADOw3BRA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Nov 2019 01:50:35 -0000

IMO we don't need to add a 3 PTO before key change. We've done performance tests with msquic and changing the key after each key update is ACK'ed and it showed absolutely no impact on throughput. As far as extra complexity it's hard to say. We implemented key update as it was spec'ed now and didn't have to make any complicated extra logic to get to this state.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3212#issuecomment-552262080