IETF Logo Mail Archive

Re: [quicwg/base-drafts] Connection ID DT output (#1742)

erickinnear <notifications@github.com> Sun, 16 September 2018 04:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0AF61130E28 for <quic-issues@ietfa.amsl.com>; Sat, 15 Sep 2018 21:36:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c-50sHErhQ5N for <quic-issues@ietfa.amsl.com>; Sat, 15 Sep 2018 21:36:19 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 62DB2127AC2 for <quic-issues@ietf.org>; Sat, 15 Sep 2018 21:36:19 -0700 (PDT)
Date: Sat, 15 Sep 2018 21:36:18 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537072578; bh=rF2LsiETcpuy5Z5Tcca9Cj3lhBKLLW4D6yPeg/WsE3k=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XHntXBKicBZw4sY+pmTwR9uoh94yC6paPkbCvfhRjpZmSUsCb7Fuw9ppyTDJ3osu3 g5FUDShlc0ToqTJwwlKa6bHLeJ2TQAg2dWCC58ocfVwg/Gc+IZ17jxfgwivE7qXQrL nwiQCzJAWHPF3fabDJYuTVTuu7G05WepNvMG2grc=
From: erickinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9983935586a05d0143c867ef559a284c9615e6d092cf0000000117b59fc292a169ce156fd3c0@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1742/review/155731693@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1742@github.com>
References: <quicwg/base-drafts/pull/1742@github.com>
Subject: Re: [quicwg/base-drafts] Connection ID DT output (#1742)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b9dddc2b0819_18fb3fd4824d45b85187f1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/J3l1YKusK_iWoxKnFXo4j4frBW0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Sep 2018 04:36:21 -0000

erickinnear commented on this pull request.



> +The fields are:
+
+Length:
+
+: An 8-bit unsigned integer containing the length of the connection ID.
+
+Connection ID:
+
+: A connection ID of the specified length.
+
+Receipt of a CONNECTION_ID_FINISHED frame containing a connection ID that was
+not previously sent to the peer MAY be treated as a connection error of type
+PROTOCOL_VIOLATION.
+
+An endpoint MUST NOT send this frame if it is currently sending packets with a
+zero-length Destination Connection ID.  Changing the length of a connection ID

Changed this for FINISHED, works more nicely with what's in NEW now. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1742#discussion_r217901825

v2.26.15 | Report a Bug | By Email | System Status