Re: [quicwg/base-drafts] Recommend replacing, not changing, protocol components (#3206)
ianswett <notifications@github.com> Fri, 08 November 2019 19:57 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D1DCF120C7E for <quic-issues@ietfa.amsl.com>; Fri, 8 Nov 2019 11:57:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wYNroPQfj8bE for <quic-issues@ietfa.amsl.com>; Fri, 8 Nov 2019 11:57:05 -0800 (PST)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8D338120C89 for <quic-issues@ietf.org>; Fri, 8 Nov 2019 11:57:05 -0800 (PST)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id D25916E172F for <quic-issues@ietf.org>; Fri, 8 Nov 2019 11:57:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573243024; bh=ECuEKjDNu+KfoMTDm8ORP2tIbXG1JZMSdzMLLmEjGcA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=BMn+Ebb8Hy6Uk6KAzfwlG+1AKlzz33MLdXmL5UJ3GKFgHzp7w9Kq2IgBhIBZV+P3H 902s0KVUxK7yzxwyK/nCosuUB1SZSPRbLSjy6A5tnoT5gXukGSMSL7o7wxceB9M2PO uxhe7C9qlhNTU20ivDULljJsOOd/xMGsek14P2RA=
Date: Fri, 08 Nov 2019 11:57:04 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3662QWD2GQBK2OEOV32L5RBEVBNHHB6AHR2I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3206/review/314427388@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3206@github.com>
References: <quicwg/base-drafts/pull/3206@github.com>
Subject: Re: [quicwg/base-drafts] Recommend replacing, not changing, protocol components (#3206)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc5c890c2cca_e0e3fb83a2cd96876334"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/J3nHQJHGtjCaZ4R3sCVdtLZJO4c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Nov 2019 19:57:09 -0000
ianswett approved this pull request. > @@ -1485,8 +1485,9 @@ requirement and SHOULD be treated as an error. Extensions that could change the semantics of existing protocol components MUST be negotiated before being used. For example, an extension that changes the layout of the HEADERS frame cannot be used until the peer has given a positive -signal that this is acceptable. In this case, it could also be necessary to -coordinate when the revised layout comes into effect. +signal that this is acceptable. Coordinating when such a revised layout comes +into effect could prove complex. As such, allocating a new identifiers for ```suggestion into effect could prove complex. As such, allocating new identifiers for ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3206#pullrequestreview-314427388
- [quicwg/base-drafts] Recommend replacing, not cha… Mike Bishop
- Re: [quicwg/base-drafts] Recommend replacing, not… Mike Bishop
- Re: [quicwg/base-drafts] Recommend replacing, not… ianswett
- Re: [quicwg/base-drafts] Recommend replacing, not… Martin Thomson
- Re: [quicwg/base-drafts] Recommend replacing, not… Mike Bishop
- Re: [quicwg/base-drafts] Recommend replacing, not… Mike Bishop