IETF Logo Mail Archive

Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)

Marten Seemann <notifications@github.com> Sun, 18 March 2018 09:38 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F1AC1127869 for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 02:38:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.626
X-Spam-Level:
X-Spam-Status: No, score=-0.626 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BaEsuy8aMoaa for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 02:38:10 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B92101200FC for <quic-issues@ietf.org>; Sun, 18 Mar 2018 02:38:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=xxo6lyAR5ZqvE3CM1kraEty+vFs=; b=dCeoSVZcZcYepA64 /LxSj2HoJIMkjqMGn9lLBjWrLUtPRSb6OqqtDZ+/bQN7Q9ta4mMe+l9f3KaF9XAP C4rtCW4BpTgjXp+yHqLroJgcrv0awH+hqN4EXWm0VhBdAs8ro6guq+Z/dnI8Y7KI JqbfsGh/vldXNNGxJoP9d9zuJzM=
Received: by filter0344p1iad2.sendgrid.net with SMTP id filter0344p1iad2-10634-5AAE3380-8 2018-03-18 09:38:08.652808177 +0000 UTC
Received: from smtp.github.com (out-3.smtp.github.com [192.30.252.194]) by ismtpd0015p1iad2.sendgrid.net (SG) with ESMTP id GFgYDEr8SxW6R5LgB7eHXQ for <quic-issues@ietf.org>; Sun, 18 Mar 2018 09:38:08.731 +0000 (UTC)
Date: Sun, 18 Mar 2018 09:38:08 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0b3930ed0b4325b50f1051e0814e90b1205fda7892cf0000000116c5f58092a169ce123fc47f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1223/review/104791125@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1223@github.com>
References: <quicwg/base-drafts/pull/1223@github.com>
Subject: Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aae3380910a1_64262b068f05aecc1972c4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2NY+ATzxwLHeqHFOVOIFUDsUpWduflHfIy6h a3F9vXOkVg+l3PkZKQXYbmdDlwbksRj+i6NyRjapp4mgJ3DEMIYWxMVRlTEy5PdSbfnJDZMOtFZgvk IAQ/wrbWLktFzv4y+Z9DIt/tdxk/CwbbsJQXrN4tGQHVxtLXQEMlknpi5mmrj6nZqGlf43GI9ARyKg E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/J59cHmNN7qAl3OjN389Qx5FDaOo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Mar 2018 09:38:11 -0000

marten-seemann commented on this pull request.



> @@ -834,19 +834,18 @@ DetectLostPackets(largest_acked):
   foreach (unacked < largest_acked.packet_number):
     time_since_sent = now() - unacked.time_sent
     delta = largest_acked.packet_number - unacked.packet_number
-    if (time_since_sent > delay_until_lost):
-      lost_packets.insert(unacked)
-    else if (delta > reordering_threshold)
-      lost_packets.insert(unacked)
+    if (time_since_sent > delay_until_lost ||
+      delta > reordering_threshold):

Got it. Fixed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1223#discussion_r175282780

v2.27.8 | Report a Bug | By Email | System Status