IETF Logo Mail Archive

Re: [quicwg/base-drafts] Send a few immediate ACKs (#2025)

ianswett <notifications@github.com> Tue, 20 November 2018 19:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2B44712D4E9 for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 11:24:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VRZgNyZ9rkmR for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 11:24:21 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BF25130DD2 for <quic-issues@ietf.org>; Tue, 20 Nov 2018 11:24:20 -0800 (PST)
Date: Tue, 20 Nov 2018 11:24:19 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542741859; bh=4a/Ra7vVmhn+bJHElggQSF5hV6a+NkdDHkrVwBpjCaw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=q3HpmTv8XA/osDItUcfKaNWY7xz6Iq2jOwkZplkATezYmxnMX73GUMSlxQYX0+HcL TZ+pIx69RXd3oBxhM5HeeqA6AoQVsg6rSDYaaAhYeivguQFFuYEBHX/38HEd3AvZ2F EEuWCbnYiRDb24NZIHqSIxcBwerT1F/o9tBCw3r0=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abde8abe27a3c195f59d80ebd75f2ca2e03caf0e7b92cf00000001180c216392a169ce16d11972@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2025/review/176935631@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2025@github.com>
References: <quicwg/base-drafts/pull/2025@github.com>
Subject: Re: [quicwg/base-drafts] Send a few immediate ACKs (#2025)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf45f6326aaa_7b8f3fb3272d45b426548f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/J9bbwKPMj4VjO4K6RuEV62XsmEM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 19:24:23 -0000

ianswett commented on this pull request.



> @@ -483,11 +483,15 @@ the peer spurious timeouts.  The maximum ack delay is communicated in the
 An acknowledgement SHOULD be sent immediately upon receipt of a second
 packet but the delay SHOULD NOT exceed the maximum ack delay. QUIC recovery
 algorithms do not assume the peer generates an acknowledgement immediately when

The intent is when you're done processing this set of packets, as clarified in the last paragraph.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2025#discussion_r235137951

v2.23.0 | Report a Bug | By Email