IETF Logo Mail Archive

Re: [quicwg/base-drafts] Servers should always send CANCEL_PUSH (#3700)

Dragana Damjanovic <notifications@github.com> Wed, 27 May 2020 12:03 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D249F3A0DD3 for <quic-issues@ietfa.amsl.com>; Wed, 27 May 2020 05:03:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dtVzOP3NE6FO for <quic-issues@ietfa.amsl.com>; Wed, 27 May 2020 05:03:15 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B14F23A0DF7 for <quic-issues@ietf.org>; Wed, 27 May 2020 05:03:01 -0700 (PDT)
Received: from github-lowworker-cf59896.ash1-iad.github.net (github-lowworker-cf59896.ash1-iad.github.net [10.56.112.26]) by smtp.github.com (Postfix) with ESMTP id D5E352C1F6D for <quic-issues@ietf.org>; Wed, 27 May 2020 05:03:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590580980; bh=N/KHBplbpgSrd2v2bTR1urjxPGy90/75QpzpecAlNAY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RbIUXpa1uJO9ZhFSNnfYQemdn8QN/KDvmByk6auK6nhoQFUXex6MdiRZHX1wLX3Zk E33Ov3POT0dWnFGIBFjJE2xgRbOophUA9ZvBwIVZiZW3SuCTXoNm3CUXP6yg98IEjh OXeP89Z6smmsHp4Ogeau1Ss3h5CPn8e95hkPvsC8=
Date: Wed, 27 May 2020 05:03:00 -0700
From: Dragana Damjanovic <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6URG3JTCOE3V2E6NN43I37JEVBNHHCKREEAQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3700/review/419122310@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3700@github.com>
References: <quicwg/base-drafts/pull/3700@github.com>
Subject: Re: [quicwg/base-drafts] Servers should always send CANCEL_PUSH (#3700)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ece56f4c6452_32053fba068cd96c92162"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ddragana
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JLB2HgbCaRa-pnMhGTxN0evmnZ4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2020 12:03:17 -0000

@ddragana commented on this pull request.



>  When a server sends CANCEL_PUSH, it is indicating that it will not be fulfilling
-a promise and has not created a push stream.  The client should not expect the
-corresponding promise to be fulfilled.
+a promise.  The client cannot expect the corresponding promise to be fulfilled.
+A server SHOULD send a CANCEL_PUSH even if it has opened the corresponding
+stream.

I think that is the right call.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3700#discussion_r431063892

v2.26.15 | Report a Bug | By Email | System Status