Re: [quicwg/base-drafts] Mandatory distinction between token types (#3128)

ianswett <notifications@github.com> Tue, 22 October 2019 13:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EE0081201DC for <quic-issues@ietfa.amsl.com>; Tue, 22 Oct 2019 06:33:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X41TdjZFTh32 for <quic-issues@ietfa.amsl.com>; Tue, 22 Oct 2019 06:33:44 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 50E24120013 for <quic-issues@ietf.org>; Tue, 22 Oct 2019 06:33:44 -0700 (PDT)
Date: Tue, 22 Oct 2019 06:33:43 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571751223; bh=x4pNfT8F55ZtBaTiNPgwy8lAe9xjVevs3/wsGkJQRFg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LoIWhqK0TuHFy8jFuDfjmJTrpKgP3kcwINV64lC5sAhUX1TjUPGi5/JUWSfqtUTp1 xHX1GdmsEqWuiZn4KJac8TAIc1zYpMN9ZWJi6mORhFrftWKfAgwYhXpkNT7kr4wjE7 oOWwBqdL5IK/86TSwAytmJ+RUwbp/yCibgaqg67s=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYEX4GYXSDBM7ACREF3XRC4PEVBNHHB43A2P4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3128/review/305207006@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3128@github.com>
References: <quicwg/base-drafts/pull/3128@github.com>
Subject: Re: [quicwg/base-drafts] Mandatory distinction between token types (#3128)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5daf05375a43b_2d1a3f9ae8ccd9641893e5"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JTKWqn-S0Pnk4ejiX2Ca8qT4Cmo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 13:33:46 -0000

ianswett approved this pull request.

Some small suggestions, but LG

>  Unlike the token that is created for a Retry packet, there might be some time
 between when the token is created and when the token is subsequently used.
 Thus, a token SHOULD have an expiration time, which could be either an explicit
 expiration time or an issued timestamp that can be used to dynamically calculate
 the expiration time.  A server can store the expiration time or include it in an
 encrypted form in the token.
 
+A token issued with NEW_TOKEN MUST NOT include information that would allow
+values to be linked by an on-path observer to the connection on which it was
+issued.  For example, it cannot include the connection ID or addressing

```suggestion
issued.  For example, it cannot include the previous connection ID or addressing
```

>  
-A client SHOULD NOT reuse a token in different connections.  Reusing a token
-allows connections to be linked by entities on the network path; see
+A client SHOULD NOT reuse a token for different connection attempts.  Reusing a

```suggestion
A client SHOULD NOT reuse a NEW_TOKEN token for different connection attempts.  Reusing a
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3128#pullrequestreview-305207006