Re: [quicwg/base-drafts] QPACK Appendix B: nameIndex (#3544)

afrind <notifications@github.com> Mon, 13 April 2020 22:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 58BBA3A1F63 for <quic-issues@ietfa.amsl.com>; Mon, 13 Apr 2020 15:21:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.175
X-Spam-Level:
X-Spam-Status: No, score=-2.175 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NxsCfmYG3Ip3 for <quic-issues@ietfa.amsl.com>; Mon, 13 Apr 2020 15:21:42 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 23E933A1F62 for <quic-issues@ietf.org>; Mon, 13 Apr 2020 15:21:41 -0700 (PDT)
Received: from github-lowworker-fa7043e.ash1-iad.github.net (github-lowworker-fa7043e.ash1-iad.github.net [10.56.109.45]) by smtp.github.com (Postfix) with ESMTP id 54C479606D3 for <quic-issues@ietf.org>; Mon, 13 Apr 2020 15:21:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586816496; bh=Zzk5jZe9oxR+mJLXqdBLh/G+5zEDPUqGZzTDtM6Sq94=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QdiwKiuLWxZryAzAlFqm909rB9CDga0I2c8y7Fysve2Ftq3pPQJCtUVLHrcUpK9yY yacKRSnzpd2YgcgxQcn2o8NYBNFO5/XNkP2qhwOM9UPbFEH2zT8iUVkpqfAv7NAoZ3 buv9FfReYw+hLrDLDT8W7rsLouhPBdi0TTIYMLu0=
Date: Mon, 13 Apr 2020 15:21:36 -0700
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3Q33MTVBK76BMX46N4UDDPBEVBNHHCF6NMAM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3544/613125869@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3544@github.com>
References: <quicwg/base-drafts/issues/3544@github.com>
Subject: Re: [quicwg/base-drafts] QPACK Appendix B: nameIndex (#3544)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e94e5f04554e_7da33fed1c2cd960454d0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JWoeF8RPBOqEHOKkf4Hc693doYY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Apr 2020 22:21:43 -0000

The code comes from a time when the index space was unified, and the first staticTable.size indexes were static and the rest were dynamic.  And yes, getNameIndex can return "not found".  I'll add some comments explaining this case and sanitize the pseudocode.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3544#issuecomment-613125869