IETF Logo Mail Archive

Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)

Lars Eggert <notifications@github.com> Sat, 02 June 2018 13:43 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8984A12D87C for <quic-issues@ietfa.amsl.com>; Sat, 2 Jun 2018 06:43:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q0M2W0UI7QLj for <quic-issues@ietfa.amsl.com>; Sat, 2 Jun 2018 06:43:28 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D2800126CD8 for <quic-issues@ietf.org>; Sat, 2 Jun 2018 06:43:27 -0700 (PDT)
Date: Sat, 02 Jun 2018 06:43:26 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1527947006; bh=KB6b//W/6hNQv87wdo/xYGG1qOnA/+YFuxWjXcO+tn4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RkVwEQcxYcLsArC/OMPEUpXPzuGA1evWxy8ECoaP5ayfjT1jn++KGTTKqbOjcJYe6 U4sT2awC5RcI01eIT1nVwzPtkMFERscMqMtufTQvV/hUCo6qxjiu4m3YP96EbDfaSV 3BeWjTn0GRm4Z7P507O1Zz96p6Kvi8Hj34KCpjDI=
From: Lars Eggert <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab51be1d913f79e26f6323b5c45f7eb322b84a9bb992cf00000001172a60fe92a169ce13656182@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1372/review/125366374@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1372@github.com>
References: <quicwg/base-drafts/pull/1372@github.com>
Subject: Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b129efe1a38f_4d142ae2570e2f54139158"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: larseggert
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JX2LBKRT7syksF6BsTLiNCKLCjc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Jun 2018 13:43:30 -0000

larseggert commented on this pull request.



> +
+The receiver side should implement three 64-bit counters that are copied to the
+ECN block when an ACK_ECN frame is generated:
+
+ECT_0:
+: Initial value = 0, incremented when a packet marked ECT(0) is received
+
+ECT_1:
+
+: Initial value = 0, incremented when a packet marked ECT(1) is received
+
+CE:
+
+: Initial value = 0, incremented when a packet marked CE is received
+
+Reception of duplicate packets SHOULD NOT increment the counters.

Agree


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1372#discussion_r192559987

v2.29.0 | Report a Bug | By Email | System Status