Re: [quicwg/base-drafts] Define INITIAL_PRIORITY frame and remove exclusive dependencies (#2075)
Lucas Pardue <notifications@github.com> Sun, 02 December 2018 21:02 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7B1E3130DBE for <quic-issues@ietfa.amsl.com>; Sun, 2 Dec 2018 13:02:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.459
X-Spam-Level:
X-Spam-Status: No, score=-9.459 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QNZ82qe3g9ig for <quic-issues@ietfa.amsl.com>; Sun, 2 Dec 2018 13:02:34 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 55FD8128D0C for <quic-issues@ietf.org>; Sun, 2 Dec 2018 13:02:34 -0800 (PST)
Date: Sun, 02 Dec 2018 13:02:33 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543784553; bh=r/eItptmGQ1UAiw0c/x4dtxQ17rCvMOF8auUAPexYk8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mJiSOlGC8TkXDSKJBa4wCmIYOCAPAosmksAbRQ/FiM05z3HIO95bWjZs+3OVpdz/v lBOTd+lYflye+7Khrl/000JK18wYtWsR5sbN5Uk3pvhzghNm26TGLiWm4Nm2RBKzfx fmD4biX+Vi7ymEDLcWxOo8BVgwsR0wBU0PlSIZKI=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd7b77213ded7cfb80c123fe05dff8859dd03b44092cf00000001181c0a6992a169ce17019477@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2075/review/180577657@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2075@github.com>
References: <quicwg/base-drafts/pull/2075@github.com>
Subject: Re: [quicwg/base-drafts] Define INITIAL_PRIORITY frame and remove exclusive dependencies (#2075)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c04486938ab5_20053fb809ad45c0208411"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JY5H4-UcJV7f_fvXL_MRd9027Xg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Dec 2018 21:02:36 -0000
LPardue commented on this pull request. > + +~~~~~~~~~~ drawing + 0 1 2 3 + 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +|DT | Empty | Element Dependency ID (i) ... ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Weight (8) | ++-+-+-+-+-+-+-+-+ +~~~~~~~~~~ +{: #fig-initial-priority title="INITIAL_PRIORITY frame payload"} + +The INITIAL_PRIORITY frame payload has the following fields: + + Dependency Type: + : A two-bit field indicating the type of element being depended on. One alternative would to have a static two-bit field that is always set to the value of `11`. There's no extra overhead since there's unused reserved bits. However, I like @kazuho's proposal and think there is room to extend it further. The PRIORITY frame definition says that > Element Dependency ID: A variable-length integer that identifies the element on which a dependency is being expressed. Depending on the value of Dependency Type, this contains the Stream ID of a request stream, the Push ID of a promised resource, the Placeholder ID of a placeholder, or is ignored. IIUC the ignored case properly, wouldn't it be more efficient to make the EDID (chuckle, not [this one](https://en.wikipedia.org/wiki/Extended_Display_Identification_Data)) optional too, based on the prioritisation type. I.e. if the dependency is root of the tree, don't send an ID. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2075#discussion_r238114436
- [quicwg/base-drafts] Define INITIAL_PRIORITY fram… Mike Bishop
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Martin Thomson
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Dmitri Tikhonov
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Ryan Hamilton
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Kazuho Oku
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Kazuho Oku
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Lucas Pardue
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Lucas Pardue
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Lucas Pardue
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Lucas Pardue
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Lucas Pardue
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Lucas Pardue
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Lucas Pardue
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Kazuho Oku
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Kazuho Oku
- Re: [quicwg/base-drafts] Define INITIAL_PRIORITY … Kazuho Oku
- Re: [quicwg/base-drafts] Define initial PRIORITY … Lucas Pardue
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Dmitri Tikhonov
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Dmitri Tikhonov
- Re: [quicwg/base-drafts] Define initial PRIORITY … Kazuho Oku
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Kazuho Oku
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Kazuho Oku
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Kazuho Oku
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Kazuho Oku
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop
- Re: [quicwg/base-drafts] Define initial PRIORITY … Mike Bishop