Re: [quicwg/base-drafts] Exception for Retire Prior To (#3643)

ianswett <notifications@github.com> Tue, 12 May 2020 13:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 00DBE3A092A for <quic-issues@ietfa.amsl.com>; Tue, 12 May 2020 06:23:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.652
X-Spam-Level:
X-Spam-Status: No, score=-1.652 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.173, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Twox2dXhV1LQ for <quic-issues@ietfa.amsl.com>; Tue, 12 May 2020 06:23:29 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B1D0E3A0922 for <quic-issues@ietf.org>; Tue, 12 May 2020 06:23:29 -0700 (PDT)
Received: from github-lowworker-a6a2749.va3-iad.github.net (github-lowworker-a6a2749.va3-iad.github.net [10.48.16.62]) by smtp.github.com (Postfix) with ESMTP id 76365E0BD9 for <quic-issues@ietf.org>; Tue, 12 May 2020 06:23:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589289807; bh=yctOR0FF4vJx2q4ek2xNwI90dTwLCXH45kKBu09j97I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ndG5jVQkTQZIwpWkWIIHpwV9g9ZDWdinCGl9zQBQdVAFXeuNVXoGpRK3EvF5sUS5A V8isljCuc2d9WdHuBQXhVaCKN3/a7dm+mgbDhnvvkzS+ZhCLYkc6IzQoaz3I4X2Eno x7ob0XchO8/2uUem/K5WNaC1kpbEqbSIw/Tl+Qko=
Date: Tue, 12 May 2020 06:23:27 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK73F5DY6KUWHG6ESXV4Y2CE7EVBNHHCJO45K4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3643/review/410035220@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3643@github.com>
References: <quicwg/base-drafts/pull/3643@github.com>
Subject: Re: [quicwg/base-drafts] Exception for Retire Prior To (#3643)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ebaa34f673f3_491a3f9346ecd95c505fa"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Jbt27iHqSoXux3DaBbBIouJh2T8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 May 2020 13:23:31 -0000

@ianswett commented on this pull request.



> +will stay within the limit.  An endpoint that receives more connection IDs than
+its advertised active_connection_id_limit MUST close the connection with an
+error of type CONNECTION_ID_LIMIT_ERROR.

```suggestion
will stay within the limit.  An endpoint that receives a NEW_CONNECTION_ID frame
with an Sequence Number more than its advertised active_connection_id_limit plus the Retire Prior To
in the frame MUST close the connection with an error of type
CONNECTION_ID_LIMIT_ERROR.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3643#pullrequestreview-410035220