Re: [quicwg/base-drafts] Use "Insert Count" rather than "Largest Reference" (#2111)

Mike Bishop <notifications@github.com> Tue, 18 December 2018 23:08 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 882BE1311EA for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 15:08:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.065
X-Spam-Level:
X-Spam-Status: No, score=-3.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uWkBuoY3Z2r2 for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 15:08:13 -0800 (PST)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 04BB91200D7 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 15:08:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=egsCLn9YWtxa1u2BYiSqNnHPSzk=; b=LMGb1nP3Awi7vqEi tkWccpd6uSuBIDBQ1k7y2IcP7YqL0aEHnfN8UhExLT+KcUEhVg8R8umAKmOrFd1i GueG5LdvfufzvY9cXlC22BDKXZaiKn2KkMGKx7NMjk6zGUirYBfa1Jx2yycppA81 fH6hGrJWAugjLPvqN83B3SmVVPY=
Received: by filter0479p1iad2.sendgrid.net with SMTP id filter0479p1iad2-20093-5C197DDB-55 2018-12-18 23:08:11.844227231 +0000 UTC m=+103623.306655603
Received: from github-lowworker-baaab27.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0021p1iad2.sendgrid.net (SG) with ESMTP id 4BQxTKwwQ0yvTzH1RSdiYQ for <quic-issues@ietf.org>; Tue, 18 Dec 2018 23:08:11.844 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-baaab27.cp1-iad.github.net (Postfix) with ESMTP id BD0E380628 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 15:08:11 -0800 (PST)
Date: Tue, 18 Dec 2018 23:08:11 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe8e693bd0c5aa1c1f2df099df679b516f544f3b592cf0000000118313fdb92a169ce17392ee3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2111/review/186323745@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2111@github.com>
References: <quicwg/base-drafts/pull/2111@github.com>
Subject: Re: [quicwg/base-drafts] Use "Insert Count" rather than "Largest Reference" (#2111)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c197ddbbbb1e_397d3f8a692d45b4485b6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1QlowWIxJCGKyb9ShFNOV4YkfoNI9ml2Li8k nhMTYoML79QG1aBqTgbs7+COaRLd9dtV6uDPh6pp4gAo1jk5TXyREmtT1gEM6BHGLrdXJmIx/ZA9MA PACoq2pK+koDz71CLNk0xrCkwjcxmuWCEjWjteRX9MpDcUb1BbUOraWaVNQKZnz8aRkgRWKPSE1HjQ 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JfQwP6wSrmzY1gnu_hdSXzy_MSY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 23:08:16 -0000

MikeBishop commented on this pull request.

I'm with Alan that this seems unnecessary.  Also, the largest reference and the number of entries inserted at the end of the encoding are often the same, but need not be.

>  
 n = count of entries inserted
 d = count of entries dropped
 ~~~~~
 {: title="Example Dynamic Table Indexing - Control Stream"}
 
 Because frames from request streams can be delivered out of order with
-instructions on the encoder stream, relative indices are relative to the Base
-Index at the beginning of the header block (see {{header-prefix}}). The Base
-Index is an absolute index. When interpreting the rest of the frame, the entry
-identified by Base Index has a relative index of zero.  The relative indices of
-entries do not change while interpreting headers on a request or push stream.
+instructions on the encoder stream, relative indices are relative to the Base at
+the beginning of the header block (see {{header-prefix}}). The Base is encoded
+as a value relative to the Insert Count, so it can be expressed as the number of
+entries inserted. The dynamic table entries up to the Base can be referenced.
+The most recently inserted entry within the limit set by the Base has a relative
+index of 0.
+
+Though new entries could be added while processing a header block, the relative
+indices of entries do not change.

In theory, you could process instructions on the encoder stream in parallel with interpreting a header block.  However, more likely this refers to entries getting inserted during encoding, and this is the wrong terminology.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2111#pullrequestreview-186323745