Re: [quicwg/base-drafts] Split PTO calculation into a dedicated method (#3681)
ianswett <notifications@github.com> Wed, 27 May 2020 14:36 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A67D23A0E65 for <quic-issues@ietfa.amsl.com>; Wed, 27 May 2020 07:36:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OuCrqVDYlfR0 for <quic-issues@ietfa.amsl.com>; Wed, 27 May 2020 07:36:33 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D6F273A0E63 for <quic-issues@ietf.org>; Wed, 27 May 2020 07:36:32 -0700 (PDT)
Received: from github-lowworker-28f8021.ac4-iad.github.net (github-lowworker-28f8021.ac4-iad.github.net [10.52.25.98]) by smtp.github.com (Postfix) with ESMTP id A09CF660327 for <quic-issues@ietf.org>; Wed, 27 May 2020 07:36:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590590191; bh=FVGc3Td/qCAUMeNqNiM47bLVVeUX0fpyu7pWe/CHuCY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dK3eomRBQlEBAkdTWXaTxHgmSaERvKyBAcjgR+hEqwbnS6FOP1AYCg+wR8K98QIQH NXdJ1KH2DuZ0WN8vkcQGhMFtyx/sYUW+ul0yOANrWFJSxKEKSRA+DQzs22pg8Hf42w EAMBZRK0FBAY9nGYthJL+LDly3NRiD8XAOiLt/ww=
Date: Wed, 27 May 2020 07:36:31 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZUH4QS5UDO3PJRFDN43JN67EVBNHHCKEI7XY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3681/review/419280843@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3681@github.com>
References: <quicwg/base-drafts/pull/3681@github.com>
Subject: Re: [quicwg/base-drafts] Split PTO calculation into a dedicated method (#3681)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ece7aef90df9_215b3fde156cd968162015"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JgSGDY4zjkEhFVkJVAdFQshoo0E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2020 14:36:35 -0000
@ianswett commented on this pull request. > space = pn_space return time, space +GetPtoTimeAndSpace(): + duration = smoothed_rtt + + max(4 * rttvar, kGranularity) * (2 ^ pto_count) Good catch, thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3681#discussion_r431186068
- [quicwg/base-drafts] Split PTO calculation into a… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… Martin Thomson
- Re: [quicwg/base-drafts] Split PTO calculation in… Martin Thomson
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… Martin Thomson
- Re: [quicwg/base-drafts] Split PTO calculation in… Marten Seemann
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… Marten Seemann
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… martinduke
- Re: [quicwg/base-drafts] Split PTO calculation in… Jana Iyengar
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… ianswett
- Re: [quicwg/base-drafts] Split PTO calculation in… Jana Iyengar
- Re: [quicwg/base-drafts] Split PTO calculation in… Jana Iyengar
- Re: [quicwg/base-drafts] Split PTO calculation in… Jana Iyengar