Re: [quicwg/base-drafts] Server's preferred address (#1251)

ianswett <notifications@github.com> Tue, 27 March 2018 19:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 66B8C12E03C for <quic-issues@ietfa.amsl.com>; Tue, 27 Mar 2018 12:00:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.009
X-Spam-Level:
X-Spam-Status: No, score=-7.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KSSqKUrU7yfb for <quic-issues@ietfa.amsl.com>; Tue, 27 Mar 2018 12:00:50 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7095112EA59 for <quic-issues@ietf.org>; Tue, 27 Mar 2018 12:00:45 -0700 (PDT)
Date: Tue, 27 Mar 2018 12:00:44 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1522177244; bh=DspGOWhtPuVpHJsBQ4p0Jy/iDM034+9Mah6PEDpKjWM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Z+2EEcq8sNUH6aUk34mDjBebBvNyng3SMwfiDYigFuvKPlTbCwjdvxM9MmgLyFpVm ylvkVD5ayds4WDDL1Bq6dwtgc5gg9XjouM774W3r95rZWRMEkV37pccRdTWN69SBZR EX/Dk1K0tFhe81jm1cfn+5a3Bx0x/4qXSjp0UJgE=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abdbb87717f9e54e89aa42a50ddf238099a2660e0092cf0000000116d256dc92a169ce126c34a9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1251/review/107424497@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1251@github.com>
References: <quicwg/base-drafts/pull/1251@github.com>
Subject: Re: [quicwg/base-drafts] Server's preferred address (#1251)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aba94dcc7a97_21c3f900964ef28200280"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JkvAGecGWmxDkxx-FGxiAMkNmi8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Mar 2018 19:00:58 -0000

ianswett approved this pull request.

Looks good, though I'm still a bit confused on the definition of probing/non-probing packets.

> +ID provided in the preferred_address transport parameter.
+
+If path validation succeeds, the client SHOULD immediately begin sending all
+non-probe packets to the new server address using the new connection ID and
+discontinue use of the old server address.  If path validation fails, the client
+MUST continue sending all future packets to the server's original IP address.
+
+### Responding to Connection Migration
+
+A server might receive a packet addressed to its preferred IP address at any
+time during the connection after the handshake is completed.  If this packet
+contains a PATH_CHALLENGE frame, the server sends a PATH_RESPONSE frame as per
+{{migrate-validate}}, but the server MUST continue sending all other packets
+from its original IP address.
+
+Once the server has received a non-probing packet on its preferred address which

I'm still confused on what probing and non-probing packets are.  Did I just miss the definition?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1251#pullrequestreview-107424497