[quicwg/base-drafts] 77217e: Always save the packet size and return early

Jana Iyengar <noreply@github.com> Thu, 26 November 2020 00:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 43E5B3A0DA1 for <quic-issues@ietfa.amsl.com>; Wed, 25 Nov 2020 16:09:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.101
X-Spam-Level:
X-Spam-Status: No, score=-2.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eGhYKVnzy1t8 for <quic-issues@ietfa.amsl.com>; Wed, 25 Nov 2020 16:09:06 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 76A403A0D9D for <quic-issues@ietf.org>; Wed, 25 Nov 2020 16:09:06 -0800 (PST)
Received: from github.com (hubbernetes-node-6d66252.ac4-iad.github.net [10.52.122.45]) by smtp.github.com (Postfix) with ESMTPA id 923E0600E32 for <quic-issues@ietf.org>; Wed, 25 Nov 2020 16:09:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1606349345; bh=atGby4sNc7weTo6fPVLR54RyXSGslAm0plSfOVf4fi0=; h=Date:From:To:Subject:From; b=2UHaiTRd5HLgvilgKH9ITulviRqdj6V+qjgNCrAHJQ68zc1jTXhzFPlGjQRY0rcUK OB88CRyDrjjv/FoapqqoU0yaYqqxPSs9tl/qnEZgB9K/hhwsIiFCWziiduaHwG/yO7 KebHo9G6e4am7A0o4gR8svW3UoJ5GJyR5kQ4sKvI=
Date: Wed, 25 Nov 2020 16:09:05 -0800
From: Jana Iyengar <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/master/fd7692-361081@github.com>
Subject: [quicwg/base-drafts] 77217e: Always save the packet size and return early
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JoGz_LDn9aV_tLwCPCo0wLCnlUY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Nov 2020 00:09:09 -0000

  Branch: refs/heads/master
  Home:   https://github.com/quicwg/base-drafts
  Commit: 77217e144e6af02768644f473df4d4c596765460
      https://github.com/quicwg/base-drafts/commit/77217e144e6af02768644f473df4d4c596765460
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-11-24 (Tue, 24 Nov 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Always save the packet size and return early

When the packet is not in_flight, return early instead of not saving the size earlier.

FIxes #4408


  Commit: 2a626247c7f564ed17522ea2ee0ba4009b070237
      https://github.com/quicwg/base-drafts/commit/2a626247c7f564ed17522ea2ee0ba4009b070237
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-11-24 (Tue, 24 Nov 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: a435847b8d88d24563fb6df35790e5cc6057b7d0
      https://github.com/quicwg/base-drafts/commit/a435847b8d88d24563fb6df35790e5cc6057b7d0
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-11-25 (Wed, 25 Nov 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md

Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>


  Commit: bffe2820703e8a29667241cc6547c763851affa9
      https://github.com/quicwg/base-drafts/commit/bffe2820703e8a29667241cc6547c763851affa9
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-11-25 (Wed, 25 Nov 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Add an assert

Only in_flight packets are added to lost_packets, so adding an assert to improve readability.


  Commit: 361081152b51777695964f81a709187d410365d3
      https://github.com/quicwg/base-drafts/commit/361081152b51777695964f81a709187d410365d3
  Author: Jana Iyengar <jri.ietf@gmail.com>
  Date:   2020-11-25 (Wed, 25 Nov 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Merge pull request #4409 from quicwg/ianswett-bytes_in_flight_in_flight

Always save the packet size and return early


Compare: https://github.com/quicwg/base-drafts/compare/fd7692b56193...361081152b51