IETF Logo Mail Archive

Re: [quicwg/base-drafts] Clarify ACK Delay and reference host-delay (#3971)

ianswett <notifications@github.com> Thu, 30 July 2020 14:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BE2693A1178 for <quic-issues@ietfa.amsl.com>; Thu, 30 Jul 2020 07:14:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x7z5h8XLw-Tr for <quic-issues@ietfa.amsl.com>; Thu, 30 Jul 2020 07:14:54 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 00DEA3A118B for <quic-issues@ietf.org>; Thu, 30 Jul 2020 07:14:46 -0700 (PDT)
Received: from github-lowworker-bb778fb.ash1-iad.github.net (github-lowworker-bb778fb.ash1-iad.github.net [10.56.102.56]) by smtp.github.com (Postfix) with ESMTP id 37DD5340EFD for <quic-issues@ietf.org>; Thu, 30 Jul 2020 07:14:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1596118486; bh=3+k8s90mnUaUsuwtAMgu8gkQVDSKrVxmHNsZi2EBEf0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iBesd31andDicQjRwhtkAUmcwpz+lwMobUA1R18N2toyHDwQ5Md8cqhH9v8uZaIiu IKyKaRRLgekcmyVFXebAnHo/YRKb41Y+k9js3tKYOjXWmC18Qina7dncYk0AAOOBQO VQ97Ujfp8QokphMcXJ3cHea7NfVpZegDg2Qpg9u4=
Date: Thu, 30 Jul 2020 07:14:46 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZAHRUQRHTDHUTGMX55F23NNEVBNHHCPTRR6M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3971/review/458442191@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3971@github.com>
References: <quicwg/base-drafts/pull/3971@github.com>
Subject: Re: [quicwg/base-drafts] Clarify ACK Delay and reference host-delay (#3971)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f22d5d6289cf_4f8216f832363b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Jv7oheHjnVRJSNAToCfCi138hDg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2020 14:14:56 -0000

@ianswett commented on this pull request.



> +: A variable-length integer representing the intentional delay in microseconds
+  between when the largest acknowledged packet, as indicated in the Largest
+  Acknowledged field, was received, and when the ACK frame was sent;
+  see {{host-delay}}.  The value of the ACK Delay field is scaled by

I flipped the ordering of this sentence, but I agree it was already too long.  I'm going to work off of @martinthomson suggestion and move the units to a separate sentence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3971#discussion_r463027359

v2.40.3 | Report a Bug | By Email | System Status