Date: Sun, 23 Dec 2018 02:41:02 -0800
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abef39de5a29aa505e818aeb489bf0866be0e74c8d92cf000000011837283e92a169ce1775e62e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2245/review/187616090@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2245@github.com>
References: <quicwg/base-drafts/pull/2245@github.com>
Subject: Re: [quicwg/base-drafts] Omit already acknowledged ACK Blocks (#2245)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c1f663edfbcd_76c03f8da12d45c411938a6";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Jvp54MOmNUc1WWbBeiHuCY8Bbus>


----==_mimepart_5c1f663edfbcd_76c03f8da12d45c411938a6
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

mikkelfj commented on this pull request.



> @@ -2858,8 +2858,8 @@ discussed in more detail in {{QUIC-RECOVERY}}.
 
 To limit ACK Blocks to those that have not yet been received by the sender, the
 receiver SHOULD track which ACK frames have been acknowledged by its peer.  Once
-an ACK frame has been acknowledged, the packets it acknowledges SHOULD NOT be
-acknowledged again.
+an ACK frame has been acknowledged, an endpoint SHOULD omit all ACK Blocks that
+have not changed since the ACK frame was sent from future ACK frames.

My rewording was to avoid a double SHOULD, but this is also fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2245#discussion_r243759184
----==_mimepart_5c1f663edfbcd_76c03f8da12d45c411938a6
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@mikkelfj</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2245#discussion_r243759184">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -2858,8 +2858,8 @@ discussed in more detail in {{QUIC-RECOVERY}}.
 
 To limit ACK Blocks to those that have not yet been received by the sender, the
 receiver SHOULD track which ACK frames have been acknowledged by its peer.  Once
-an ACK frame has been acknowledged, the packets it acknowledges SHOULD NOT be
-acknowledged again.
+an ACK frame has been acknowledged, an endpoint SHOULD omit all ACK Blocks that
+have not changed since the ACK frame was sent from future ACK frames.
</pre>
<p>My rewording was to avoid a double SHOULD, but this is also fine.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2245#discussion_r243759184">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq_xaV2LGuXIIHst8_qsZi9QdzYBfks5u712-gaJpZM4ZfJKd">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkqzvtUHT2Q9YK-BQ5LmPyDmrFpJokks5u712-gaJpZM4ZfJKd.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mikkelfj commented on #2245"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2245#discussion_r243759184"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2245#discussion_r243759184",
"url": "https://github.com/quicwg/base-drafts/pull/2245#discussion_r243759184",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c1f663edfbcd_76c03f8da12d45c411938a6--