Re: [quicwg/base-drafts] Better articulate principles for ciphersuites (#2743)

Nick Harper <notifications@github.com> Wed, 22 May 2019 10:04 UTC

Date: Wed, 22 May 2019 03:04:51 -0700
From: Nick Harper <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2OW6Y5PI2QBA7K2CF26JIUHEVBNHHBVJKNCE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2743/review/240531329@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2743@github.com>
References: <quicwg/base-drafts/pull/2743@github.com>
Subject: Re: [quicwg/base-drafts] Better articulate principles for ciphersuites (#2743)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ce51ec3d10ee_660f3fa7b18cd96067978b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JwWVPz3n3VyntmYyCUoWcO9CHXs>

nharper commented on this pull request.



> @@ -964,10 +970,12 @@ sample.
 To ensure that sufficient data is available for sampling, packets are padded so
 that the combined lengths of the encoded packet number and protected payload is
 at least 4 bytes longer than the sample required for header protection.  For the
-AEAD functions defined in {{?TLS13}}, which have 16-byte expansions and 16-byte
-header protection samples, this results in needing at least 3 bytes of frames in
-the unprotected payload if the packet number is encoded on a single byte, or 2
-bytes of frames for a 2-byte packet number encoding.
+ciphersuites defined in {{?TLS13}} - other than TLS_AES_128_CCM_8_SHA256, for

Nit: Remove "For" (the sentence should start "The ciphersuites defined in").

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2743#pullrequestreview-240531329

[quicwg/base-drafts] Better articulate principles… Martin Thomson
Re: [quicwg/base-drafts] Better articulate princi… Nick Harper
Re: [quicwg/base-drafts] Better articulate princi… Rui Paulo
Re: [quicwg/base-drafts] Better articulate princi… ekr
Re: [quicwg/base-drafts] Better articulate princi… Kazuho Oku
Re: [quicwg/base-drafts] Better articulate princi… Marten Seemann
Re: [quicwg/base-drafts] Better articulate princi… Martin Thomson
Re: [quicwg/base-drafts] Better articulate princi… Martin Thomson
Re: [quicwg/base-drafts] Better articulate princi… MikkelFJ
Re: [quicwg/base-drafts] Better articulate princi… MikkelFJ
Re: [quicwg/base-drafts] Better articulate princi… ekr