IETF Logo Mail Archive

Re: [quicwg/base-drafts] Adjust autotuning recommendations (#2240)

janaiyengar <notifications@github.com> Fri, 21 December 2018 20:13 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0B44C130E9C for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 12:13:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.661
X-Spam-Level:
X-Spam-Status: No, score=-1.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l-9QcCNGFftF for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 12:13:18 -0800 (PST)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E083130E94 for <quic-issues@ietf.org>; Fri, 21 Dec 2018 12:13:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=fHkNY6VV/vpYSoIOFDRc3QbnpPI=; b=YrkwiGi9kfKBJJE+ 8dLxyORzALqHGriQtnqqiTPtYW2L2x1RnbPZA8XQoe43vs1OVcMtn4K4f20dCxGt trzvz9kRs/uPVwX8J9MbpoWxTuoavqhRgHX8JHjN4Dy5Xl3K0ugDVI/G2nmiutk5 14sWpvQ3s4bzMaq670ecUwePEH4=
Received: by filter0911p1las1.sendgrid.net with SMTP id filter0911p1las1-30215-5C1D495B-14 2018-12-21 20:13:15.839589408 +0000 UTC m=+686237.242934269
Received: from github-lowworker-0b1e58d.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0036p1iad1.sendgrid.net (SG) with ESMTP id m7AVswz7S0WtF-3m2GQ2Mg for <quic-issues@ietf.org>; Fri, 21 Dec 2018 20:13:15.799 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-0b1e58d.cp1-iad.github.net (Postfix) with ESMTP id C1B413E1175 for <quic-issues@ietf.org>; Fri, 21 Dec 2018 12:13:15 -0800 (PST)
Date: Fri, 21 Dec 2018 20:13:16 +0000
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0607738df7813c5061ac65d537cf2eb03497e49e92cf0000000118350b5b92a169ce17718705@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2240/review/187525404@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2240@github.com>
References: <quicwg/base-drafts/pull/2240@github.com>
Subject: Re: [quicwg/base-drafts] Adjust autotuning recommendations (#2240)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1d495bc0384_5e2a3f94612d45bc765a3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3Hbir/fDq+23GILqkwED45kayIWBZJsi6MiY 35umniKOjjdXDS1in4xIT/cG6ssmOyuSjsEMI6/8iqtxMKqe5Qyez73Sj1RyP0APdnqubObQVS8PDN AXJdVEY55gjRw8CaXqw2FODMeWhE++TzZ9NZHMVd6Ff0pnKiumkqMQJCZqF6llswt4UBzqUVedwsFY 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/JxUC5AaD4XXtCJ7hdETtmYyvqC4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 20:13:20 -0000

janaiyengar commented on this pull request.



>  advertised additional credit based on a round-trip time estimate and the rate at
 which the receiving application consumes data, similar to common TCP
-implementations.
+implementations.  Sending frames related to flow control only when there are
+other frames to send or when a peer is blocked ensures that flow control doesn't

This sentence is very vague, and I'm not sure I find it useful. What issue is it tackling?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2240#pullrequestreview-187525404

v2.30.2 | Report a Bug | By Email | System Status