Re: [quicwg/base-drafts] QPACK [editorial] Misc minor editorial changes. (#2942)

Bence Béky <> Wed, 31 July 2019 17:20 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 1E2FB12049D for <>; Wed, 31 Jul 2019 10:20:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.595
X-Spam-Status: No, score=-6.595 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.001, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id bIjW5kjVp9Xs for <>; Wed, 31 Jul 2019 10:20:01 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id C8F7B1203D6 for <>; Wed, 31 Jul 2019 10:20:00 -0700 (PDT)
Date: Wed, 31 Jul 2019 10:19:59 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1564593599; bh=JPALJ+9YSOElaML22KGql312ngKSfEpKy60R8u1w2Tc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cW7KONF6uOnnZqUbefVqGJ1it7Y1CtnH7q3euSpmhQJN5Ixen+4g3mgFtAIFvildB aH2QJnfHHTp7xR8MyDsZ4qHHM7UprBOXpdpJowZtWc4xelru+8I9cpkFH7zuiK6A4j 4uwOnP4J7FAaEux6JGGsEH14S5wEReMLDDWNHl9s=
From: =?UTF-8?B?QmVuY2UgQsOpa3k=?= <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2942/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] QPACK [editorial] Misc minor editorial changes. (#2942)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d41cdbfd0f61_45313fa16d0cd96c129611"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 31 Jul 2019 17:20:02 -0000

bencebeky commented on this pull request.

> @@ -830,10 +831,8 @@ modifying it.
 Each header block is prefixed with two integers.  The Required Insert Count is
 encoded as an integer with an 8-bit prefix after the encoding described in
-{{ric}}).  The Base is encoded as sign-and-modulus integer, using a single sign

A cursory web search shows that "sign-and-magnitude" is used a lot more often than "sign-and-modulus", which might conjure images of modulo arithmetic.  I propose not to put a name on this encoding, since there's an off-by-one that's not common for sign-and-modulus representations anyway.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: