Re: [quicwg/base-drafts] Largest Reference too big (#1404)

afrind <notifications@github.com> Thu, 31 May 2018 16:46 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 97E2312EBEF for <quic-issues@ietfa.amsl.com>; Thu, 31 May 2018 09:46:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sZmJw0OGQfFa for <quic-issues@ietfa.amsl.com>; Thu, 31 May 2018 09:46:49 -0700 (PDT)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 905B512EC1C for <quic-issues@ietf.org>; Thu, 31 May 2018 09:46:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=iKag2F+05nYCRrZdxBvpxk6WA5k=; b=LrkYCHvacQ5qHHaF UIjfO07mLs6vWk5BrjMoq0/1c8/BgmgHqmT/Re92QaMAVYxBpanZ86rBTXe5leXR XnICAPWkJ+li9iupVC8IDvSB+kszgoldpnZvlNckoJN1bLr0+IGoBxWKdzhqdgZ1 vg7cym4DIx8TtKio/B13hF3uGUM=
Received: by filter1565p1mdw1.sendgrid.net with SMTP id filter1565p1mdw1-3398-5B1026F7-24 2018-05-31 16:46:47.426741121 +0000 UTC
Received: from github-lowworker9-cp1-prd.iad.github.net (unknown [192.30.252.47]) by ismtpd0010p1iad1.sendgrid.net (SG) with ESMTP id hp2VkQdwRgqD5bXPNuNJbg for <quic-issues@ietf.org>; Thu, 31 May 2018 16:46:47.412 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker9-cp1-prd.iad.github.net (Postfix) with ESMTP id 60A449FD67 for <quic-issues@ietf.org>; Thu, 31 May 2018 09:46:47 -0700 (PDT)
Date: Thu, 31 May 2018 16:46:47 +0000
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1e01499f4954766f836dea82b9c6fb5c99eb9cec92cf000000011727e8f792a169ce138cb60c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1404/393597561@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1404@github.com>
References: <quicwg/base-drafts/issues/1404@github.com>
Subject: Re: [quicwg/base-drafts] Largest Reference too big (#1404)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b1026f75ee21_5ec53fb6e9b3ef7c828f6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2eOw4dE3mD7v+6XFlHgvxURFb9uT/23KWpvb yG4CvO2HWwKLqmRJmZ2ZRQ08UOJNUxeAom2J58sjWEQw1yWi1mZcK2nxu2xqNvt7nvpDLdhOzpKEMl WQUXykY/BH/Ad777HQUBneG7B5H8nqSPLuEpie11/on7yH7rWyBUkqmDAw==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/K8gSEPrqnN3UXHXwFsXV9UBeHG4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 May 2018 16:46:52 -0000

I don't think we should require the decoder to fail the stream if it doesn't actually make a reference as large as Largest Reference.  Making it larger than needed will only delay decoding (possibly indefinitely).  I think it can only happen because there's a bug in the encoder or the encoder is attacking the decoder.  

It's seems odd to say the decoder MAY fail the stream/connection when this happens.  I feel like we should say it's an error or it's not.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1404#issuecomment-393597561