Re: [quicwg/base-drafts] Rework flow of Push ID (#3925)
Bence Béky <notifications@github.com> Wed, 22 July 2020 18:49 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D157E3A0039 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 11:49:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kuLaM3q_2gf6 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 11:49:50 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 57F1E3A0033 for <quic-issues@ietf.org>; Wed, 22 Jul 2020 11:49:50 -0700 (PDT)
Received: from github-lowworker-1ac52d7.ash1-iad.github.net (github-lowworker-1ac52d7.ash1-iad.github.net [10.56.25.52]) by smtp.github.com (Postfix) with ESMTP id 57C87E183D for <quic-issues@ietf.org>; Wed, 22 Jul 2020 11:49:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595443789; bh=HqK0TgRavI3FFV0augBIc2WgjmW/32raaQmyCjhFl7U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=E4Hv5lFX4HpNFaCZlkNOOUc9VEkcPx1N9zRCly6N9sEE5aKT5XjQ5IGCh5p5Lw50v BLdRd9niX2C8MQoQRjj7ZI+fTdlvOwSX9+JThjWUqQ02uXRShl93O/SaJxk7Ju9d/K ID5XirmaHVBh19bqFGxi35+0Jljj4s4FajOv0pb0=
Date: Wed, 22 Jul 2020 11:49:49 -0700
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ3OARHB6EO6AKYRKV5ERVU3EVBNHHCPBRDMY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3925/review/453592674@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3925@github.com>
References: <quicwg/base-drafts/pull/3925@github.com>
Subject: Re: [quicwg/base-drafts] Rework flow of Push ID (#3925)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f188a4d47e29_226c3f8a604cd9644142e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/K8zYlh1BqhaULuWwqreTpy4WEZ0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2020 18:49:52 -0000
@bencebeky commented on this pull request. > - -Server push is only enabled on a connection when a client sends a MAX_PUSH_ID -frame; see {{frame-max-push-id}}. A server cannot use server push until it -receives a MAX_PUSH_ID frame. A client sends additional MAX_PUSH_ID frames to -control the number of pushes that a server can promise. A server SHOULD use Push -IDs sequentially, starting at 0. A client MUST treat receipt of a push stream -with a Push ID that is greater than the maximum Push ID as a connection error of -type H3_ID_ERROR. +Each server push is assigned a unique Push ID by the server which is used to +refer to the push in various contexts throughout the lifetime of the connection. + +The Push ID space begins at zero, and ends at a maximum value set by the +MAX_PUSH_ID frame; see {{frame-max-push-id}}. In particular, a server is not +able to push until after the client sends a MAX_PUSH_ID frame. A client sends +additional MAX_PUSH_ID frames to control the number of pushes that a server can +promise. A server SHOULD use Push IDs sequentially, beginning from zero. A "A client sends additional MAX_PUSH_ID frames...". This sentence kind of implies that the very first MAX_PUSH_ID frame does not control the number of pushed that a server is allowed to promise, only the subsequent MAX_PUSH_ID frames. Maybe remove this sentence altogether, because {{frame-max-push-id}} is already doing a great job explaining how the client can send such frames to allow for new push promises as the server fulfills or cancels existing ones? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3925#pullrequestreview-453592674
- [quicwg/base-drafts] Rework flow of Push ID (#392… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Martin Thomson
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… ianswett
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop