Re: [quicwg/base-drafts] Add details of marking packets lost on PTO (#2624)

ianswett <notifications@github.com> Tue, 16 April 2019 10:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE0631204DC for <quic-issues@ietfa.amsl.com>; Tue, 16 Apr 2019 03:39:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F3-iNEx-ztRY for <quic-issues@ietfa.amsl.com>; Tue, 16 Apr 2019 03:39:31 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EF1BF1204AD for <quic-issues@ietf.org>; Tue, 16 Apr 2019 03:39:30 -0700 (PDT)
Date: Tue, 16 Apr 2019 03:39:29 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555411169; bh=pNUCUj2sDRwuM8GZBUftg4hCuDtN3M6fgfz9KLc1DQ4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QubG0SakOIHkhgdJ7cp+ByQK20K6zY1auNNHtkvTB/i3RrnK5Eo1KxzEG3U0+oEis IYQfqmpBJwE17v6F2niVXf3HMfvcuKuZ+XpUkksaHPd0TKzaPViXn7IvA3GXM/tzqU OeK8N1EM2YuvwBW4lft+T84AvoxFMZgnBERKcuAo=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab152eb55273083a02b713ee26aba39f0a506546ec92cebac2e36192a169ce19d6a975@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2624/review/227114494@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2624@github.com>
References: <quicwg/base-drafts/pull/2624@github.com>
Subject: Re: [quicwg/base-drafts] Add details of marking packets lost on PTO (#2624)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb5b0e1a3b90_33a73faaa42d45b8929f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KIS4qTimcus-h9_WxOGOAU28YnA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2019 10:39:33 -0000

ianswett commented on this pull request.



> @@ -623,10 +623,21 @@ time.
 
 ### Sending Probe Packets
 
-When a PTO timer expires, the sender MUST send one ack-eliciting packet as a
-probe, unless there is nothing to send. A sender MAY send up to two
-ack-eliciting packets, to avoid an expensive consecutive PTO expiration due
-to a single packet loss.
+When a PTO timer expires, a sender MUST send at least one ack-eliciting packet
+as a probe, unless there is no data available to send.  An endpoint MAY send up
+to two ack-eliciting packets, to avoid an expensive consecutive PTO expiration
+due to a single packet loss.
+
+It is possible that the sender has no new or previously-sent data to send.  For
+example, this can happen when there is no new application data to send and all
+streams with data in flight are reset (see Section 13.2 of {{QUIC-TRANSPORT}}).

As Nick Banks has repeatedly pointed out, when you reset a stream, you send a STREAM_RESET frame, which is ack-eliciting, so this example doesn't really hold up that well.  A MESSAGE/DATAGRAM frame is the easiest real-world example because it's ack-eliciting and unreliable, but it's not in the v1 draft :(

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2624#pullrequestreview-227114494