Re: [quicwg/base-drafts] Adds text about server padding handshake to PMTU (#1013)
Christian Huitema <notifications@github.com> Sun, 24 December 2017 00:54 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AB966126CD8 for <quic-issues@ietfa.amsl.com>; Sat, 23 Dec 2017 16:54:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.03
X-Spam-Level:
X-Spam-Status: No, score=-2.03 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R-FJY34Rews0 for <quic-issues@ietfa.amsl.com>; Sat, 23 Dec 2017 16:54:03 -0800 (PST)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 60CE01200C1 for <quic-issues@ietf.org>; Sat, 23 Dec 2017 16:54:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Rxo8sP2zFRQ3TshGhUSkLAvfx+c=; b=to5Ce7Obl8x0ju/o RKiwmRawMyKgAecwfhmQc1PErj/MAj170qPGFh3FT7iXeJ58Jdgl858qcPgDSE6p e4n1OahYetIJbpJvSjCCR0Cq4OJ2Wktt/BV25TmeXA8nLyoxRJmhFniSnjkOqxsw +6fkJR5wNWJDYD4XrjlvpOPQWNw=
Received: by filter0182p1las1.sendgrid.net with SMTP id filter0182p1las1-8283-5A3EFAAA-8 2017-12-24 00:54:02.272558666 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id 3SeEU0EhT66--_VwaigadA for <quic-issues@ietf.org>; Sun, 24 Dec 2017 00:54:02.188 +0000 (UTC)
Date: Sun, 24 Dec 2017 00:54:02 +0000
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2eaa60482a1ed288bdf7d710264ada97396aba2992cf000000011656bcaa92a169ce10c994a9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1013/review/85431920@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1013@github.com>
References: <quicwg/base-drafts/pull/1013@github.com>
Subject: Re: [quicwg/base-drafts] Adds text about server padding handshake to PMTU (#1013)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a3efaaa17a0d_876e3fd042334f3019481d9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak17falsBcaJqg2OWW2oPMZuJ6Gbp6E4Rs+8j/ Z4b+YwhRJRL1xm4RIrhZ5AyUBJaabxqc2BjcLOY8xhS9wiIAcMYeQE7vXA+KI79lq3YjXVRrJ1XExn D6eG6jpagKKZ8ib+ReB3egueCe1ESGTfGGCEfzoDqR1Mv1senI3bznDRIqkDZ9QnaBbIOCE2/Qt8zL c=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KKqXYt7OUgPqzq59N_1OPrvfiJE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Dec 2017 00:54:06 -0000
huitema commented on this pull request. The current text on the "minimum enforced MTU" is contorted and spread over several paragraphs. I think the paragraph explaining that "QUIC depends on the network path supporting a MTU of at least 1280 octets" should be moved up, just after the introduction of path MTU, and before making statements such as "In the absence of these mechanisms, QUIC endpoints SHOULD NOT send IP packets larger than 1280 octets." Once this is said, we can have the additional text on server handshake messages. But we need to work some more on that text. > Servers MUST ignore an initial plaintext packet from a client if its total size is less than 1200 octets. +Similarly, servers MUST ensure that the first handshake packet they send to +clients, and any retransmissions of those octets, has a QUIC packet size that is +the same as the received initial client packet, unless the server knows the PMTU +to the client to be smaller. Sending a packet of this size ensures that the The client side "at least 1200 byte" is justified by a security concern, but that concern does not apply to server responses. I think we need some better text, and that the justification for the padding should come after the requirement of minimum 1280 MTU. Setting a minimum size for the first handshake packet ensures that the handshake will fail if the network does not support the recommended MTU, and is only justified if we want enforce the "minimum 1280" requirement. But if we do that, maybe we should develop the idea in a full paragraph. For example, is it OK to meet the requirement in IPv4 by setting the DF bit to "fragmentation authorized"? > Servers MUST ignore an initial plaintext packet from a client if its total size is less than 1200 octets. +Similarly, servers MUST ensure that the first handshake packet they send to +clients, and any retransmissions of those octets, has a QUIC packet size that is +the same as the received initial client packet, unless the server knows the PMTU +to the client to be smaller. Sending a packet of this size ensures that the I am a bit skeptical about the requirement for "any retransmissions of those octets". It will be yet another special case in the handling of re-transmission. The net effect will be that servers pad all handshake message re-transmissions to 1200 bytes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1013#pullrequestreview-85431920
- [quicwg/base-drafts] Adds text about server paddi… janaiyengar
- Re: [quicwg/base-drafts] Adds text about server p… janaiyengar
- Re: [quicwg/base-drafts] Adds text about server p… Martin Thomson
- Re: [quicwg/base-drafts] Adds text about server p… Christian Huitema
- Re: [quicwg/base-drafts] Adds text about server p… Martin Thomson
- Re: [quicwg/base-drafts] Adds text about server p… Martin Thomson
- Re: [quicwg/base-drafts] Adds text about server p… janaiyengar
- Re: [quicwg/base-drafts] Adds text about server p… janaiyengar