Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 39967120845
 for <quic-issues@ietfa.amsl.com>; Tue, 15 Oct 2019 10:48:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level: 
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001,
 HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id MtJyPFhpoSft for <quic-issues@ietfa.amsl.com>;
 Tue, 15 Oct 2019 10:48:54 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id ACA57120840
 for <quic-issues@ietf.org>; Tue, 15 Oct 2019 10:48:54 -0700 (PDT)
Received: from github-lowworker-275fa97.va3-iad.github.net
 (github-lowworker-275fa97.va3-iad.github.net [10.48.17.64])
 by smtp.github.com (Postfix) with ESMTP id 08DFB1C2EBB
 for <quic-issues@ietf.org>; Tue, 15 Oct 2019 10:48:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1571161734;
 bh=pxpNY8DsTF0g2PmwxsE5sOJghEyJq2WOFNj47uO8kZE=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=MZGGgfvw8C0H5bnZjJ+GFd8vdZ3kGT3KZG9+yNC+xyi6OhyKwNkxkg7Ak1brSqTUk
 uZiGxriAkOsMm45dSdeYcD9/sNwQMjCrGVyfq+uBfHeQ25Yt1TyNGvVD7gdxFaD0JH
 6QMAJUL7E0qpThk5OdMJK4/QYNbojW1Bmx7+ZCDY=
Date: Tue, 15 Oct 2019 10:48:53 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK5V6YXPZ2YBG2M5ASN3WNDRLEVBNHHBZ4IYAM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2993/review/302086957@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2993@github.com>
References: <quicwg/base-drafts/pull/2993@github.com>
Subject: Re: [quicwg/base-drafts] Stateless reset comparisons (constant
 time/any order/datagram) (#2993)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5da60685edc10_7d093f95094cd960707040";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KROlE2LxXFHEOrZa9dpbAfJU9qs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2019 17:48:57 -0000


----==_mimepart_5da60685edc10_7d093f95094cd960707040
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

janaiyengar commented on this pull request.



> @@ -2529,20 +2529,35 @@ the packet other than the last 16 bytes for carrying data.
 
 ### Detecting a Stateless Reset
 
-An endpoint detects a potential stateless reset when an incoming packet either
-cannot be associated with a connection, cannot be decrypted, or is marked as a
-duplicate packet.  The endpoint MUST then compare the last 16 bytes of the
-packet with all Stateless Reset Tokens that are associated with connection IDs
-that the endpoint recently used to send packets from the IP address and port on
-which the datagram is received.  This includes Stateless Reset Tokens from
-NEW_CONNECTION_ID frames and the server's transport parameters.  An endpoint
-MUST NOT check for any Stateless Reset Tokens associated with connection IDs it
-has not used or for connection IDs that have been retired.
-
-If the last 16 bytes of the packet values are identical to a Stateless Reset
+An endpoint detects a potential stateless reset using the trailing 16 bytes of
+the UDP datagram.  The endpoint compare the last 16 bytes of the datagram with

```suggestion
the UDP datagram.  The endpoint compares the last 16 bytes of the datagram with
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2993#pullrequestreview-302086957
----==_mimepart_5da60685edc10_7d093f95094cd960707040
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@janaiyengar</b> commented on this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/2993#discussi=
on_r335091819">draft-ietf-quic-transport.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -2529,20 +2529,35 @@ the packet other t=
han the last 16 bytes for carrying data.=0D
 =0D
 ### Detecting a Stateless Reset=0D
 =0D
-An endpoint detects a potential stateless reset when an incoming packet =
either=0D
-cannot be associated with a connection, cannot be decrypted, or is marke=
d as a=0D
-duplicate packet.  The endpoint MUST then compare the last 16 bytes of t=
he=0D
-packet with all Stateless Reset Tokens that are associated with connecti=
on IDs=0D
-that the endpoint recently used to send packets from the IP address and =
port on=0D
-which the datagram is received.  This includes Stateless Reset Tokens fr=
om=0D
-NEW_CONNECTION_ID frames and the server&#39;s transport parameters.  An =
endpoint=0D
-MUST NOT check for any Stateless Reset Tokens associated with connection=
 IDs it=0D
-has not used or for connection IDs that have been retired.=0D
-=0D
-If the last 16 bytes of the packet values are identical to a Stateless R=
eset=0D
+An endpoint detects a potential stateless reset using the trailing 16 by=
tes of=0D
+the UDP datagram.  The endpoint compare the last 16 bytes of the datagra=
m with=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-the UDP datagram.  The endpoint compare the l=
ast 16 bytes of the datagram with=0D
+the UDP datagram.  The endpoint compares the last 16 bytes of the datagr=
am with=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/2993?email_source=3Dnotifications&amp;email_token=3DA=
FTOJK2SSUZBBAXY2XBUR4TQOX7ALA5CNFSM4IP3T762YY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIAXWLI#pullrequestreview-302086957=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJK52E3WEC4FG465OFMDQOX7ALANCNFSM4IP3T76Q">unsubscribe=
</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJK7FIEOH2JNT=
4ZMA4WTQOX7ALA5CNFSM4IP3T762YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWN=
FSXPKTDN5WW2ZLOORPWSZGOCIAXWLI.gif" height=3D"1" width=3D"1" alt=3D"" /><=
/p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/2993?email_source=3D=
notifications\u0026email_token=3DAFTOJK2SSUZBBAXY2XBUR4TQOX7ALA5CNFSM4IP3=
T762YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC=
IAXWLI#pullrequestreview-302086957",=0D
"url": "https://github.com/quicwg/base-drafts/pull/2993?email_source=3Dno=
tifications\u0026email_token=3DAFTOJK2SSUZBBAXY2XBUR4TQOX7ALA5CNFSM4IP3T7=
62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIA=
XWLI#pullrequestreview-302086957",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5da60685edc10_7d093f95094cd960707040--

