Re: [quicwg/base-drafts] Try again to use ECN? (#4029)

Gorry Fairhurst <notifications@github.com> Tue, 25 August 2020 10:07 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 53DCF3A0BFF for <quic-issues@ietfa.amsl.com>; Tue, 25 Aug 2020 03:07:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.501
X-Spam-Level:
X-Spam-Status: No, score=-0.501 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dSpDtsP0tEvn for <quic-issues@ietfa.amsl.com>; Tue, 25 Aug 2020 03:07:43 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 11C763A0BFD for <quic-issues@ietf.org>; Tue, 25 Aug 2020 03:07:42 -0700 (PDT)
Received: from github-lowworker-28f8021.ac4-iad.github.net (github-lowworker-28f8021.ac4-iad.github.net [10.52.25.98]) by smtp.github.com (Postfix) with ESMTP id 4654B520E5F for <quic-issues@ietf.org>; Tue, 25 Aug 2020 03:07:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598350062; bh=mCh4ArT1uLDOI5XBB3qvVTt+Fg+8ogA0ncT0PUCkemM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yn5huOiAB0l+mjFmrm2EIy04uEeWtbTtEYiVf9ZzylL053t1L8QfSpQ0Jvq6oiN/Z IwpfxJdG1787SYQmSdQdmwlLlGHX9t+8d+4Wgh8pNr74CzJ00qRpsBUvf0Tu5mfsE3 GMQhFmzwJktsQdRV2lacyo1FENyeXMOe5nK26NVo=
Date: Tue, 25 Aug 2020 03:07:42 -0700
From: Gorry Fairhurst <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZWUJ7GM2IBAOTQ5F55KDB65EVBNHHCRJHOV4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/4029/679932911@github.com>
In-Reply-To: <quicwg/base-drafts/issues/4029@github.com>
References: <quicwg/base-drafts/issues/4029@github.com>
Subject: Re: [quicwg/base-drafts] Try again to use ECN? (#4029)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f44e2ee36640_9af196412466e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gorryfair
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KU-FGZ9QWa6HUAdJg-jFOjC0KSw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Aug 2020 10:07:44 -0000

I think PR 4037 needs surgery. The intent seems pretty clear. I believe root cause of the comments originate from text that isn't perfected. There's lots of colloquial terminology mistakes wrt ECN, some repetition, a few para ordering problems  and few sentences needing polish. If we fix all these then maybe (nearly) all the issues will disappear. 

@martinthomson ... can I offer to edit the PR text in this section?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/4029#issuecomment-679932911