Re: [quicwg/base-drafts] RTT sample should be taken only once for each largest_acked (#2569)

Nick Banks <> Sat, 30 March 2019 22:45 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 76CED12006E for <>; Sat, 30 Mar 2019 15:45:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.598
X-Spam-Status: No, score=-6.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id kiM_rfSlIyn6 for <>; Sat, 30 Mar 2019 15:45:17 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 96173120004 for <>; Sat, 30 Mar 2019 15:45:17 -0700 (PDT)
Date: Sat, 30 Mar 2019 15:45:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1553985916; bh=eux3zbAYEEXuW5jDXbm4RVXAs6HG+Y/2EReIaeAHmYU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Cfcdjg3XxZ1TlxUC07NfCugTpjT6PoEP/+BTDx6igghYNdjZcSOU9PH7l6lJEFxzt gv/xe5TJBWDOYJbQQnWqt6qP6hW3nxsL6icHXuDrlu9KY2FQS5u+Pa3T801G6ZmbiN +/zp0Pcb3MJUwx4DVyqvLpv1BIPxFarPQ97wZoeI=
From: Nick Banks <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/issues/2569/>
In-Reply-To: <quicwg/base-drafts/issues/>
References: <quicwg/base-drafts/issues/>
Subject: Re: [quicwg/base-drafts] RTT sample should be taken only once for each largest_acked (#2569)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c9ff17c2a3d9_54013f81ed4d45b4160241"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Sat, 30 Mar 2019 22:45:20 -0000

To be fair, the comment in the pseudo code does say only to update the rtt if it's newly acked:
  // If the largest acknowledged is newly acked and
  // ack-eliciting, update the RTT.
  if (sent_packets[pn_space][ack.largest_acked] &&
Personally, I'd solve this by always setting `sent_packets[pn_space][#] = null` once it has been acknowledged. Then the pseudo code above would be correct.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: