Date: Sat, 30 Mar 2019 15:45:16 -0700
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab19b0b6e404f58ee6b3708f5a486424b8faff1edb92cf0000000118b7b37c92a169ce1978875a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2569/478295940@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2569@github.com>
References: <quicwg/base-drafts/issues/2569@github.com>
Subject: Re: [quicwg/base-drafts] RTT sample should be taken only once for
 each largest_acked (#2569)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c9ff17c2a3d9_54013f81ed4d45b4160241";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KU1PvjyjHbYK211OtcsZcVnpMp8>


----==_mimepart_5c9ff17c2a3d9_54013f81ed4d45b4160241
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

To be fair, the comment in the pseudo code does say only to update the rtt if it's newly acked:
```
  // If the largest acknowledged is newly acked and
  // ack-eliciting, update the RTT.
  if (sent_packets[pn_space][ack.largest_acked] &&
      sent_packets[pn_space][ack.largest_acked].ack_eliciting):
```
Personally, I'd solve this by always setting `sent_packets[pn_space][#] = null` once it has been acknowledged. Then the pseudo code above would be correct.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2569#issuecomment-478295940
----==_mimepart_5c9ff17c2a3d9_54013f81ed4d45b4160241
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p>To be fair, the comment in the pseudo code does say only to update the=
 rtt if it's newly acked:</p>
<pre><code>  // If the largest acknowledged is newly acked and
  // ack-eliciting, update the RTT.
  if (sent_packets[pn_space][ack.largest_acked] &amp;&amp;
      sent_packets[pn_space][ack.largest_acked].ack_eliciting):
</code></pre>
<p>Personally, I'd solve this by always setting <code>sent_packets[pn_spa=
ce][#] =3D null</code> once it has been acknowledged. Then the pseudo cod=
e above would be correct.</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/issues/2569#issuecomment-478295940">view it on GitHub</a>,=
 or <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkq9n2=
JPFfnCyAEI48fHezdviFylqeks5vb-j8gaJpZM4cT-Zj">mute the thread</a>.<img sr=
c=3D"https://github.com/notifications/beacon/AWbkqy7eBfwhZYYA9d246senI3S4=
ZtZqks5vb-j8gaJpZM4cT-Zj.gif" height=3D"1" width=3D"1" alt=3D"" /></p>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://github.githubassets.com/images/email/message_cards/header.png","avata=
r_image_url":"https://github.githubassets.com/images/email/message_cards/=
avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/q=
uicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@=
nibanks in #2569: To be fair, the comment in the pseudo code does say onl=
y to update the rtt if it's newly acked:\r\n```\r\n  // If the largest ac=
knowledged is newly acked and\r\n  // ack-eliciting, update the RTT.\r\n =
 if (sent_packets[pn_space][ack.largest_acked] \u0026\u0026\r\n      sent=
_packets[pn_space][ack.largest_acked].ack_eliciting):\r\n```\r\nPersonall=
y, I'd solve this by always setting `sent_packets[pn_space][#] =3D null` =
once it has been acknowledged. Then the pseudo code above would be correc=
t."}],"action":{"name":"View Issue","url":"https://github.com/quicwg/base=
-drafts/issues/2569#issuecomment-478295940"}}}</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/issues/2569#issuecomment=
-478295940",
"url": "https://github.com/quicwg/base-drafts/issues/2569#issuecomment-47=
8295940",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>=

----==_mimepart_5c9ff17c2a3d9_54013f81ed4d45b4160241--