Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B74603A10D4 for ; Thu, 30 Jul 2020 05:32:11 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -1.482 X-Spam-Level: X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YN1rGleQkpgi for ; Thu, 30 Jul 2020 05:32:10 -0700 (PDT) Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DCFD53A10D2 for ; Thu, 30 Jul 2020 05:32:09 -0700 (PDT) Received: from github-lowworker-f62aa54.va3-iad.github.net (github-lowworker-f62aa54.va3-iad.github.net [10.48.17.68]) by smtp.github.com (Postfix) with ESMTP id 0386F902515 for ; Thu, 30 Jul 2020 05:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1596112329; bh=TjgkC7by6M7wGzjaDAUSIW5jf28JiAypgaSJUhx7bEc=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=Lb/YHeJNG7OVdKEOCZ9TpBs9Nr9G1ClggRsgF2FLV2Y2YmjC4bjHhTFUHOW4+vOXw H9koy5BJOqF5I8j+f52EideDniMoi0AZKpg79DjyZuGhlXrryzgGQ/a5t/xFhpi2r6 IJty9w1R+I75kEv4UPD1iPAY1/kCEIpxEruJruAI= Date: Thu, 30 Jul 2020 05:32:08 -0700 From: Alessandro Ghedini Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: Subject: [quicwg/base-drafts] Don't apply PTO backoff twice in GetPtoTimeAndSpace() (#3974) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5f22bdc8e852f_5c3616f81241e1"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: ghedo X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2020 12:32:12 -0000 ----==_mimepart_5f22bdc8e852f_5c3616f81241e1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit >From the recovery draft pseudo-code: ``` GetPtoTimeAndSpace(): duration = (smoothed_rtt + max(4 * rttvar, kGranularity)) * (2 ^ pto_count) ``` then later: ``` duration += max_ack_delay * (2 ^ pto_count) ``` so `pto_count` seems to be applied twice to `duration`, which I think is a mistake. You can view, comment on, or merge this pull request online at: https://github.com/quicwg/base-drafts/pull/3974 -- Commit Summary -- * Don't apply PTO backoff twice in GetPtoTimeAndSpace() -- File Changes -- M draft-ietf-quic-recovery.md (4) -- Patch Links -- https://github.com/quicwg/base-drafts/pull/3974.patch https://github.com/quicwg/base-drafts/pull/3974.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3974 ----==_mimepart_5f22bdc8e852f_5c3616f81241e1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

From the recovery draft pseudo-code:

GetPtoTimeAndSpace():
  duration = (smoothed_rtt + max(4 * rttvar, kGranularity))
      * (2 ^ pto_count)

then later:

      duration += max_ack_delay * (2 ^ pto_count)

so pto_count seems to be applied twice to duration, which I think is
a mistake.

You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/3974

Commit Summary

  • Don't apply PTO backoff twice in GetPtoTimeAndSpace()

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

----==_mimepart_5f22bdc8e852f_5c3616f81241e1--