Date: Tue, 25 Sep 2018 20:11:07 +0000 (UTC)
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab4cded3e5f1ee287c04492c64526cd4abf390222992cf0000000117c2585b92a169ce15a88727@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1794/review/158723563@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1794@github.com>
References: <quicwg/base-drafts/pull/1794@github.com>
Subject: Re: [quicwg/base-drafts] Only include a token in the "first" Initial
 (#1794)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5baa965b44edc_699e3fb55f4d45b4139252";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KXYeCiJinw5Od8Hc2i5ZCK5cRqw>

----==_mimepart_5baa965b44edc_699e3fb55f4d45b4139252
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -621,10 +621,19 @@ packet. It also sets the Token field to the token provided in the Retry. The
 client MUST NOT change the Source Connection ID because the server could include
 the connection ID as part of its token validation logic (see {{tokens}}).
 
+The Initial packet sent by the client in response to a Retry packet is subject
+to the same restrictions as the first Initial packet, with the exception of the
+value of the Destination Connection ID and Token fields, which are set as
+described here.  A client can either reuse the cryptographic handshake message
+or construct a new one at its discretion.  Any subsequent Initial packets from
+the client MUST use the same connection ID values, and MUST NOT include the

I thought the Retry now must change the CID?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1794#pullrequestreview-158723563
----==_mimepart_5baa965b44edc_699e3fb55f4d45b4139252
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1794#discussion_r220337752">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -621,10 +621,19 @@ packet. It also sets the Token field to the token provided in the Retry. The
 client MUST NOT change the Source Connection ID because the server could include
 the connection ID as part of its token validation logic (see {{tokens}}).
 
+The Initial packet sent by the client in response to a Retry packet is subject
+to the same restrictions as the first Initial packet, with the exception of the
+value of the Destination Connection ID and Token fields, which are set as
+described here.  A client can either reuse the cryptographic handshake message
+or construct a new one at its discretion.  Any subsequent Initial packets from
+the client MUST use the same connection ID values, and MUST NOT include the
</pre>
<p>I thought the Retry now must change the CID?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1794#pullrequestreview-158723563">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq9_Nxi-3a4fGKv7ROU7q8PxP-S-Mks5ueo3bgaJpZM4W3qeS">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq7ZUivxAiTJQHPYWDrrjMwTN1GJWks5ueo3bgaJpZM4W3qeS.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ianswett commented on #1794"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1794#pullrequestreview-158723563"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1794#pullrequestreview-158723563",
"url": "https://github.com/quicwg/base-drafts/pull/1794#pullrequestreview-158723563",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ianswett commented on 1794",
"sections": [
{
"text": "",
"activityTitle": "**ianswett**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ianswett",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1794#pullrequestreview-158723563"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 383690642\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5baa965b44edc_699e3fb55f4d45b4139252--