IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add sequence number to NCID frame (#1821)

ianswett <notifications@github.com> Tue, 02 October 2018 17:06 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7813C13117A for <quic-issues@ietfa.amsl.com>; Tue, 2 Oct 2018 10:06:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.456
X-Spam-Level:
X-Spam-Status: No, score=-8.456 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id weN4pyb0koRg for <quic-issues@ietfa.amsl.com>; Tue, 2 Oct 2018 10:06:12 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D1659131181 for <quic-issues@ietf.org>; Tue, 2 Oct 2018 10:02:18 -0700 (PDT)
Date: Tue, 02 Oct 2018 10:02:17 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538499737; bh=lE0oFdZS7DnR0SawJCL1XgWPOfxvUfdOTSet888W1A0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=C23Yq2EIDa6Xu52ZDNnrYx8bx+Q8+xx4FnNKO6CkSyopgq5VJtdDuVLGriv+2nSKd zoX0X+eodqBg6imQF0t2BpHv1hVZeIAm6IO5Y9UFLSuhaTnnjRqxNNX/9rCLf+lM7F r9pmnP3XzSUYUV7/Fie3ZLAhNtSw+5oLN7qkXJrg=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb507c0b627e7aed0bfdde86e839aefea3a045af392cf0000000117cb669992a169ce15d05805@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1821/review/160825068@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1821@github.com>
References: <quicwg/base-drafts/pull/1821@github.com>
Subject: Re: [quicwg/base-drafts] Add sequence number to NCID frame (#1821)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb3a4998c15b_a3d3f9c314d45c43870f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KYFqCTHeqBJFSVSf7fDpFlKcLw4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 17:06:15 -0000

ianswett commented on this pull request.



> @@ -3285,8 +3292,10 @@ zero-length Destination Connection ID MUST treat receipt of a NEW_CONNECTION_ID
 frame as a connection error of type PROTOCOL_VIOLATION.
 
 Transmission errors, timeouts and retransmissions might cause the same
-NEW_CONNECTION_ID frame to be received multiple times. Receipt of the same
-frame multiple times MUST NOT be treated as a connection error.
+NEW_CONNECTION_ID frame to be received multiple times.  Receipt of the same
+frame multiple times MUST NOT be treated as a connection error.  A receiver can
+use the sequence number supplied in the NEW_CONNECTION_ID frame to identify new
+connection IDs from old ones.

Q: What happens if the CID sequence number increases by a large amount(ie: 1000)?  If the same sequence number arrives with a different connection ID, is the receiver supposed to close the connection, ignore the second one?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1821#pullrequestreview-160825068

v2.23.0 | Report a Bug | By Email