Re: [quicwg/base-drafts] Send a few immediate ACKs (#2025)

MikkelFJ <notifications@github.com> Tue, 20 November 2018 18:55 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0A90D130DDE for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 10:55:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1pehuCy0-bUt for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 10:55:08 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DA8A3130E50 for <quic-issues@ietf.org>; Tue, 20 Nov 2018 10:55:06 -0800 (PST)
Date: Tue, 20 Nov 2018 10:55:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542740106; bh=TaT3+ykJPzzSISM/5THsC90ptDZD3s3CmoS1dFkLnGc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1EyyEroJagI/cIk75VEEgaloSiXvl5lrRabD3kxLrPUiSAfmdq0mRnJFKtREHX+x3 6EEW3Z9iUG7xm65y12hBJZWPZu6sF06mzbynTUER9TYYnpzOX/wMWU2Yljxw5BbYTk YRFJLlA4eyEE01nfohfeI3vsq6teUcEBfbw5neKA=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab67660b4b81ba1b5542abfb8a6adad3e10415c63e92cf00000001180c1a8a92a169ce16d11972@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2025/review/176923314@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2025@github.com>
References: <quicwg/base-drafts/pull/2025@github.com>
Subject: Re: [quicwg/base-drafts] Send a few immediate ACKs (#2025)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf4588a2585c_5f473ff6592d45bc1988ed"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Kb4FDyTCeU01xJV7yPAHE6RzIsI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 18:55:13 -0000

mikkelfj commented on this pull request.



> @@ -483,11 +483,15 @@ the peer spurious timeouts.  The maximum ack delay is communicated in the
 An acknowledgement SHOULD be sent immediately upon receipt of a second
 packet but the delay SHOULD NOT exceed the maximum ack delay. QUIC recovery
 algorithms do not assume the peer generates an acknowledgement immediately when

does immediately mean ASAP or any convenient time before ACK delay ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2025#pullrequestreview-176923314