Re: [quicwg/base-drafts] consider making the varint encoding unique (#2299)

Martin Thomson <notifications@github.com> Mon, 07 January 2019 00:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E8DF71310C2 for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 16:02:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lE8e8vkUmcr9 for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 16:02:46 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2D4E71310BE for <quic-issues@ietf.org>; Sun, 6 Jan 2019 16:02:46 -0800 (PST)
Date: Sun, 06 Jan 2019 16:02:45 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546819365; bh=5xWP4khqRDzRJMTG7ETk436llDiIgsLcSEyN06x2oEA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1ec9kMuVIwLo3vdg95D88u/Kem0lfeHMz6YcK46pMFD8DArMASOKo/l0TbJzkZvP0 Tje2fjE2CewF3QS4qLUsEvV1lGeVlOE73W49AOuWKjMxJhIaW1pLyPJWD9oYyz1061 +dpTHF2TastxRKiOA5KUNnS7QjrrwioxkKrt7jMA=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1d9fa8a5e5b93e968e70dcb84760e1effdadd90392cf00000001184a592592a169ce179e43e2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2299/451788047@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2299@github.com>
References: <quicwg/base-drafts/issues/2299@github.com>
Subject: Re: [quicwg/base-drafts] consider making the varint encoding unique (#2299)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3297255bb87_6c543fc6f42d45c45469bd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KdxcgpMoA78G4B-nSIYRPE7me2M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 00:02:48 -0000

I'm pretty sure that this was a case where @ekr said that a canonical encoding would be silly.  That's certainly my view.

I believe that this would be a fairly significant hit both in terms of code complexity and performance.  If you think that you can make the case, I think we might start with a PR [here](https://github.com/martinthomson/quic-int) to show that a) the code is simple enough, and b) the performance is tolerable.  Then there is the point about churn.

The requirement on minimal encodings for frame types exists so that a frame decoder can be more efficient, as @mikkelfj says.  I'm reluctant to add that requirement in too many places though (even in the h3 cases we are currently considering).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2299#issuecomment-451788047