Re: [quicwg/base-drafts] loss detection timer description could be simplified by definining a timer mode (#3151)

ianswett <notifications@github.com> Sat, 02 November 2019 19:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A907E1200B4 for <quic-issues@ietfa.amsl.com>; Sat, 2 Nov 2019 12:12:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BdAICOT7vGhQ for <quic-issues@ietfa.amsl.com>; Sat, 2 Nov 2019 12:12:35 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AD6F3120086 for <quic-issues@ietf.org>; Sat, 2 Nov 2019 12:11:25 -0700 (PDT)
Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id B3AB26E0A6D for <quic-issues@ietf.org>; Sat, 2 Nov 2019 12:11:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572721884; bh=up5cLMKIkXW9TgzbjYlRZjhoJeQ3pLVT1liUJZGlnC4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wMA89gDMNfnCa9HT0a+bY5U96PLdzHA6eB799mlFyBzYIXnqVygxljdC45ZZT4uLp 4Fn+slgWm+b4ZKRSJny6PznhV3PLpi9CcryPUEpKs58qGdcKdQ4563Quhe6NCQfSfS 5+/EJWR7eeGv4Qvq5AxPTVyVfiqI92oy257EdRLg=
Date: Sat, 02 Nov 2019 12:11:24 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4MWENJKNX5G7EDYRV3ZMKWZEVBNHHB5CCZQY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3151/549072303@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3151@github.com>
References: <quicwg/base-drafts/issues/3151@github.com>
Subject: Re: [quicwg/base-drafts] loss detection timer description could be simplified by definining a timer mode (#3151)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dbdd4dca3a09_2b143f7e7eecd95c949863"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Ke0CGkrmsBHv0vh5x6jFzbuInYM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Nov 2019 19:12:37 -0000

One other idea would be to add a second timer, so you'd have a loss_timer and pto_timer.  I was strongly against this when we had handshake retransmissions and TLP retransmissions and RTO retransmissions, but now that we're down to PTO, I like the idea better.  I think that might be simpler to understand than an enum, and you could split the pseudocode into two methods.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3151#issuecomment-549072303