Re: [quicwg/base-drafts] use the FRAME_ENCONDING_ERROR for errors in frame encoding (#3042)

Martin Thomson <notifications@github.com> Tue, 17 September 2019 03:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9E1281200FB for <quic-issues@ietfa.amsl.com>; Mon, 16 Sep 2019 20:17:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.596
X-Spam-Level:
X-Spam-Status: No, score=-1.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GB_SUMOF=5, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o3jTrqhtAe9v for <quic-issues@ietfa.amsl.com>; Mon, 16 Sep 2019 20:17:39 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AD601120018 for <quic-issues@ietf.org>; Mon, 16 Sep 2019 20:17:39 -0700 (PDT)
Date: Mon, 16 Sep 2019 20:17:38 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568690258; bh=Myb8z3OKXwxuOwocjyS5XsPeffRZidHUTQ+myxB8jgA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rwYYHjKWnttyUwiVYA7k7CUZcdZDZThCnYxSuxKI+lv8mZZT10JBdB4r41sc/od8A PDvZYwjW6H/zO0X5voWz+7kBUrbwaLJ8c08YKMEcolaQMsjFaTUnLtRG6IY5ld0RWk AMWklRqt5FIG9V8O8YM2brF72y3MsozN8SBvq+aE=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7CRDZCTNDMCC2IDJF3RV2MFEVBNHHB253VH4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3042/review/288999898@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3042@github.com>
References: <quicwg/base-drafts/pull/3042@github.com>
Subject: Re: [quicwg/base-drafts] use the FRAME_ENCONDING_ERROR for errors in frame encoding (#3042)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d805052355aa_3c4e3fab470cd9605564d"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KgysAAokquyA9qaTI_i3ZzsPsyw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Sep 2019 03:17:41 -0000

martinthomson approved this pull request.

LGTM, with maybe a note on the flow control one.

> @@ -5061,7 +5060,7 @@ The first byte in the stream has an offset of 0.  The largest offset delivered
 on a stream - the sum of the offset and data length - cannot exceed 2^62-1, as
 it is not possible to provide flow control credit for that data.  Receipt of a
 frame that exceeds this limit will be treated as a connection error of type
-FLOW_CONTROL_ERROR.
+FRAME_ENCODING_ERROR.

This creates an extra check that some implementations might not bother to implement.  Treating this as a flow control error is also fine.  I note that this doesn't use a MUST either...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3042#pullrequestreview-288999898