Re: [quicwg/base-drafts] Improve language on evictable entries. (#3131)

Bence Béky <notifications@github.com> Thu, 20 February 2020 18:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C374B12004F for <quic-issues@ietfa.amsl.com>; Thu, 20 Feb 2020 10:22:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JgGmCzdUDVqh for <quic-issues@ietfa.amsl.com>; Thu, 20 Feb 2020 10:22:14 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A3CD312004E for <quic-issues@ietf.org>; Thu, 20 Feb 2020 10:22:14 -0800 (PST)
Received: from github-lowworker-25680bd.va3-iad.github.net (github-lowworker-25680bd.va3-iad.github.net [10.48.17.61]) by smtp.github.com (Postfix) with ESMTP id 7D31D660DF2 for <quic-issues@ietf.org>; Thu, 20 Feb 2020 10:22:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582222933; bh=8ksuJ+mMhvgFa4payT9tupi05H8/Gmec31Uya80Jmg4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=M+i2ZZbglEqIN5rPFPX4QZn1p7erzTL3nNxf6Y6F3yYhbVEujL1xrC0dK2582sYPq nvUw9u1fsuf8pIm2Zn4sfAPriWZ6KB6tua45L/ctZZbf8hNoyiTQYuIhFplB8t/yJa CyQEBuiwgxFDGnpAb+EJA1QfW9InE8GAo/rPdvEU=
Date: Thu, 20 Feb 2020 10:22:13 -0800
From: =?UTF-8?B?QmVuY2UgQsOpa3k=?= <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2UZYBMRHXYAYG3OYN4LQANLEVBNHHB45IJ64@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3131/review/362128649@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3131@github.com>
References: <quicwg/base-drafts/pull/3131@github.com>
Subject: Re: [quicwg/base-drafts] Improve language on evictable entries. (#3131)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e4ece556d99d_1f6a3fcd386cd96011814a"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Kl4tlnuQWoYVMZzNRaTdZZacIjc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Feb 2020 18:22:17 -0000

bencebeky commented on this pull request.



>  ### Limits on Dynamic Table Insertions {#blocked-insertion}
 
 Inserting entries into the dynamic table might not be possible if the table
 contains entries which cannot be evicted.
 
 A dynamic table entry cannot be evicted immediately after insertion, even if it
 has never been referenced. Once the insertion of a dynamic table entry has been
-acknowledged and there are no outstanding unacknowledged references to the
-entry, the entry becomes evictable.
+acknowledged and there are no outstanding references to the entry in
+unacknowledged header blocks, the entry becomes evictable.  Note that
+unacknowledged references on the encoder stream do not preclude the eviction of

I have a slight preference of adding an explicit note that encoder stream references do not count, to make sure no one unnecessarily implements tracking for them (like I foolishly did).  But I'm flexible as far as wording is concerned, and do not insist on adding this note if you don't believe it adds any value.  Let me know what you think.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3131#discussion_r382175737