Re: [quicwg/base-drafts] Fix QPACK-04 changelog: add two non-editorial changes (#2102)
Martin Thomson <notifications@github.com> Thu, 13 December 2018 06:38 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 28C9C128CFD for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 22:38:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.459
X-Spam-Level:
X-Spam-Status: No, score=-9.459 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a6ScXkjy437o for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 22:38:13 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2282412875B for <quic-issues@ietf.org>; Wed, 12 Dec 2018 22:38:13 -0800 (PST)
Date: Wed, 12 Dec 2018 22:38:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544683092; bh=6qlTo4xMSfRko+ijuII439/FkPso6/4x/UXkee0Ud5I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ricy//iXD8PUUVzaaM/7aVD/OevhdTUvJ9nJ84oOx3wJYnZ5DKIdGEl0DLNHl9KPo TWgh/w1rB9oIdaUfp7iEEUa84UdwSZZ9LXLys5d62GZt8PR6TZIMc71/KRKf7oii61 VIEbnwF9sEn1zG6dkZEDWOlg+YDy2b1T8VX9BGRs=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2171af544b9e1611a7724c6c3bfa4d6712e314b692cf000000011829c05492a169ce1723d5fa@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2102/review/184518165@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2102@github.com>
References: <quicwg/base-drafts/pull/2102@github.com>
Subject: Re: [quicwg/base-drafts] Fix QPACK-04 changelog: add two non-editorial changes (#2102)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c11fe5440e94_22bd3f80436d45b8331031"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KojJUBTFALvZRQTpJ7II0ertZ-Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 06:38:15 -0000
martinthomson requested changes on this pull request. I added the #2005 mention to the -05 changelog. The other fix is a good one. > @@ -1254,7 +1254,9 @@ return controlBuffer, prefixBuffer + streamBuffer ## Since draft-ietf-quic-qpack-03 -Substantial editorial reorganization; no technical changes. +- Avoid having multiple ways to encode Delta Base Index of zero (#2005) Based on the tags on drafts, this change is in -05, not -04. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2102#pullrequestreview-184518165
- [quicwg/base-drafts] Fix QPACK-04 changelog: add … Dmitri Tikhonov
- Re: [quicwg/base-drafts] Fix QPACK-04 changelog: … Mike Bishop
- Re: [quicwg/base-drafts] Fix QPACK-04 changelog: … Martin Thomson
- Re: [quicwg/base-drafts] Fix QPACK-04 changelog: … Dmitri Tikhonov
- Re: [quicwg/base-drafts] Fix QPACK-04 changelog: … Dmitri Tikhonov
- Re: [quicwg/base-drafts] Fix QPACK-04 changelog: … Martin Thomson
- Re: [quicwg/base-drafts] Fix QPACK-04 changelog: … afrind