Re: [quicwg/base-drafts] Prevent linkability from responding to migration (#2969)

Eric Kinnear <notifications@github.com> Mon, 19 August 2019 21:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BE8341200CD for <quic-issues@ietfa.amsl.com>; Mon, 19 Aug 2019 14:25:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oZJJEIDMM-h8 for <quic-issues@ietfa.amsl.com>; Mon, 19 Aug 2019 14:25:46 -0700 (PDT)
Received: from out-9.smtp.github.com (out-9.smtp.github.com [192.30.254.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 961A7120048 for <quic-issues@ietf.org>; Mon, 19 Aug 2019 14:25:46 -0700 (PDT)
Date: Mon, 19 Aug 2019 14:25:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566249946; bh=Ua+8ziPclmpm66g8FXwDoA4bLra2sX9G8aXmkGTOxRQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oNCN9oPxyJ5Muvav1J04f06eS65+PRGM+H8xK8J6zVJshxAMcMl87CAGug5TZgfSb qIBymvrzslNNE6qCkts8a1YHebtKrfU1rO7nYYkmUYkQ9qiVcIBNRDoISpfdt029c7 dD9GbgYq19bB2RaJW/cSt+jtJsjjvKk1hctU7Zn4=
From: Eric Kinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK576GMW5BRZZ7HTC2V3NBDFTEVBNHHBZKYFBA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2969/review/276821582@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2969@github.com>
References: <quicwg/base-drafts/pull/2969@github.com>
Subject: Re: [quicwg/base-drafts] Prevent linkability from responding to migration (#2969)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d5b13d9d1b8a_754a3ffabfacd95c990ba"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Kth2fiyEJmXENXDRq2AkURE0TO4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Aug 2019 21:25:49 -0000

erickinnear approved this pull request.

Thanks for writing this up! Content looks great, just two minor wording questions and this looks ready to go.

> @@ -2077,9 +2084,13 @@ genuine migrations.  Changing port number can cause a peer to reset its
 congestion state (see {{migration-cc}}), so the port SHOULD only be changed
 infrequently.
 
-An endpoint that exhausts available connection IDs cannot migrate.  To ensure
-that migration is possible and packets sent on different paths cannot be
-correlated, endpoints SHOULD provide new connection IDs before peers migrate.
+An endpoint that exhausts available connection IDs cannot migrate.  Similarly,
+an endpoint is unable to respond to probes or an attempt by its peer to migrate

This sentence parses oddly for me, I assume it's in the context of the previous sentence, but maybe something like
```
An endpoint that exhausts available connection IDs cannot probe new paths or initiate 
migration, nor can it respond to probes or attempts by its peer to migrate.
```
and replace both sentences.
(Not providing that as a suggested change since it'll mess up the wrapping, sorry!)

> @@ -2077,9 +2084,13 @@ genuine migrations.  Changing port number can cause a peer to reset its
 congestion state (see {{migration-cc}}), so the port SHOULD only be changed
 infrequently.
 
-An endpoint that exhausts available connection IDs cannot migrate.  To ensure
-that migration is possible and packets sent on different paths cannot be
-correlated, endpoints SHOULD provide new connection IDs before peers migrate.
+An endpoint that exhausts available connection IDs cannot migrate.  Similarly,
+an endpoint is unable to respond to probes or an attempt by its peer to migrate
+or probe.  To ensure that migration is possible and packets sent on different
+paths cannot be correlated, endpoints SHOULD provide new connection IDs before
+peers migrate.  If a peer might have exhausted available connection IDs, a

Do we want to reference the other section that talks about SHOULD provide a new CID for every one that gets retired, etc.? I think that's `{{issue-cid}}`.

Specifically the below paragraph: 
```
An endpoint SHOULD supply a new connection ID when it receives a packet with a
previously unused connection ID or when the peer retires one, unless providing
the new connection ID would exceed the peer's limit.  An endpoint MAY limit the
frequency or the total number of connection IDs issued for each connection to
avoid the risk of running out of connection IDs; see {{reset-token}}.
```

```suggestion
peers migrate ({{issue-cid}}).  If a peer might have exhausted available connection IDs, a
```

If that doesn't mess up the spacing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2969#pullrequestreview-276821582