Re: [quicwg/base-drafts] Limit CWND increase in slow start (#3232)

[Junho Choi <[e-mail]>]

junhochoi commented on this pull request.



> @@ -1368,7 +1377,15 @@ acked_packet from sent_packets.
        return
      if (congestion_window < ssthresh):
        // Slow start.
-       congestion_window += acked_packet.size
+       if (pacing):
+         congestion_window += acked_packet.size
+       else:
+         // If pacing is not used, limit the increase to
+         // 2*max_datagram_size per ACK as described in
+         // {{?RFC3465}}
+         if (cwnd_increase < 2 * max_datagram_size):
+           cwnd_increase += bytes_acked
+           congestion_window += bytes_acked

I think this may allow increasing cwnd close to (3 x max_datagram_size).

e.g. max_datagram_size = 1000
ack 1 = 999 bytes
ack 2 = 999 bytes
ack 3 = 999 bytes

If we have 3 acks each acks 999 bytes, this code result in 999x3 bytes cwnd increase. 

To calculate remaining bytes correctly, I would propose the following:

```
  OnAckReceivedCC():
     cwnd_incr_max = 2 * max_datagram_size
...
  OnPacketAckedCC(acked_packet):
...
         // If pacing is not used, limit the increase to
         // 2*max_datagram_size per ACK as described in
         // {{?RFC3465}}
         cwnd_incr = cwnd_incr_max - max(cwnd_incr_max - acked_packet.size, 0)
         congestion_window += cwnd_incr
         cwnd_incr_max -= cnwd_incr
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3232#discussion_r345506253