Re: [quicwg/base-drafts] Consider simplifying Packet Number Encryption (#1575)

David Schinazi <notifications@github.com> Sat, 29 September 2018 17:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E8D86130DCB for <quic-issues@ietfa.amsl.com>; Sat, 29 Sep 2018 10:38:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ykHOMILj0UU6 for <quic-issues@ietfa.amsl.com>; Sat, 29 Sep 2018 10:38:06 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 909101286D9 for <quic-issues@ietf.org>; Sat, 29 Sep 2018 10:38:06 -0700 (PDT)
Date: Sat, 29 Sep 2018 10:38:05 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538242685; bh=3+2tDaYyn7NbFBBgTN01ppPJKvGdiHan1k6icWFadso=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=We1CKKxVUdlnUgoQNQUhD9xHF2H5YcPleTyGmVY/3j2D7mrHFjqFOO+F/o/kHd0KP E3QAIb6+NtAu/5201Grqru7FtPciLnHn/j1J+Sbtnm70WTqUcIxd1fylX39QPVIrBF W6apcYbqzI66vc1D5KdBVwMkdwfQpx5YNRffAvew=
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd6f6cc6b02e394da8fb88c6ba58747f9ce3b59a692cf0000000117c77a7d92a169ce14620d9d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1575/425662595@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1575@github.com>
References: <quicwg/base-drafts/issues/1575@github.com>
Subject: Re: [quicwg/base-drafts] Consider simplifying Packet Number Encryption (#1575)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bafb87d454c3_71f53fb14dcd45b81586fe"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: DavidSchinazi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/L1fZJiUnoNFWhVxljZnR5U4eKSg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Sep 2018 17:38:09 -0000

I think requiring 3 octets of frames is more restrictive that we need to be. I would prefer saying that QUIC packets MUST verify `length(packet number) + length(payload) >= 4`, and if implementors want to do that by always ensuring 3 bytes of frames that's fine.

I meant that we XOR over the payload if the packet number length is < 4. When we're encrypting the PN, I'm not sure the distinction between PN and payload is relevant - there's nothing wrong with changing the start of the payload in my mind. And it simplifies the implementation.

But we can put this on hold until we've landed on what the PN encoding looks like.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1575#issuecomment-425662595