Re: [quicwg/base-drafts] Notify the congestion controller of losses first (#3540)

ianswett <notifications@github.com> Tue, 31 March 2020 16:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1EE733A23AE for <quic-issues@ietfa.amsl.com>; Tue, 31 Mar 2020 09:08:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.5
X-Spam-Level:
X-Spam-Status: No, score=-0.5 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wt-T5s8I5v9x for <quic-issues@ietfa.amsl.com>; Tue, 31 Mar 2020 09:08:40 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 278A13A23A7 for <quic-issues@ietf.org>; Tue, 31 Mar 2020 09:08:40 -0700 (PDT)
Received: from github-lowworker-ca5950c.va3-iad.github.net (github-lowworker-ca5950c.va3-iad.github.net [10.48.17.57]) by smtp.github.com (Postfix) with ESMTP id 727058C1CDC for <quic-issues@ietf.org>; Tue, 31 Mar 2020 09:08:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1585670919; bh=ZGbnCsAl1LzoFxo3d490i9SCQgzJFgN+4KVR/IS5BZE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JqfPaCGLzDkdLx8ylHBZ+mETPl8LXsOFM13rziP6nLOeKW+fF3nxdFzEldad3o0zt PPNDjBSHGLh+UO5nLn//fcoy8ibbzCcIMTuHn2Afw4oSLa+c0nKymBPWlzWAkYbJCK M7h3OWrgU10Ypz5uSj5l7BAGEt1052+Y6d6Knx/A=
Date: Tue, 31 Mar 2020 09:08:39 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4TEUQTQGVLKC2IMQ54R5GAPEVBNHHCF2VMJI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3540/review/384887115@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3540@github.com>
References: <quicwg/base-drafts/pull/3540@github.com>
Subject: Re: [quicwg/base-drafts] Notify the congestion controller of losses first (#3540)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e836b0763346_48ad3fc00d4cd968107690"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/L6CDeMbSZ3EoFFnhiz3iJmcq9Eo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2020 16:08:43 -0000

@ianswett commented on this pull request.



> @@ -1517,7 +1494,7 @@ Invoked from DetectLostPackets when packets are deemed lost.
      CongestionEvent(largest_lost_packet.time_sent)

I'm not a big fan of largest here and above.  If you want to make the change, maybe another PR, since this one is already quite large.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3540#discussion_r401036031