Re: [quicwg/base-drafts] Rework flow of Push ID (#3925)
Lucas Pardue <notifications@github.com> Tue, 21 July 2020 18:34 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F29FA3A0477 for <quic-issues@ietfa.amsl.com>; Tue, 21 Jul 2020 11:34:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7MinNXMfLMDN for <quic-issues@ietfa.amsl.com>; Tue, 21 Jul 2020 11:34:55 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AFA353A046D for <quic-issues@ietf.org>; Tue, 21 Jul 2020 11:34:55 -0700 (PDT)
Received: from github-lowworker-c53a806.ac4-iad.github.net (github-lowworker-c53a806.ac4-iad.github.net [10.52.23.45]) by smtp.github.com (Postfix) with ESMTP id E4F29282D18 for <quic-issues@ietf.org>; Tue, 21 Jul 2020 11:34:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595356494; bh=aXbjCZZf5adrXJzySr0LKQd1rHiFbO1aStqiZ4vOBbI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uWVVNQW4e2o823Yqf+fO9fENZ2bnArK4srNJayP2yuCy3UKPzBNAHG7TIvJ3SiSry 60iTDQEoNtRHyshgMD2ry3fG2uW/CaQR8XvOHV1PgcgV1bkbvz4Y5fmVESUossV2y9 E8nkfFmQXN64TBQX94WM5bA2nRw08q78FtrJsqcM=
Date: Tue, 21 Jul 2020 11:34:54 -0700
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6PNOBF67HBC7JEX455EMLE5EVBNHHCPBRDMY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3925/review/452727255@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3925@github.com>
References: <quicwg/base-drafts/pull/3925@github.com>
Subject: Re: [quicwg/base-drafts] Rework flow of Push ID (#3925)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f17354ed3abf_6f823fcad8ccd96c155343"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/L8vbUREpKVNf_AkfdP0GrfJibww>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jul 2020 18:34:57 -0000
@LPardue commented on this pull request. > - -Server push is only enabled on a connection when a client sends a MAX_PUSH_ID -frame; see {{frame-max-push-id}}. A server cannot use server push until it -receives a MAX_PUSH_ID frame. A client sends additional MAX_PUSH_ID frames to -control the number of pushes that a server can promise. A server SHOULD use Push -IDs sequentially, starting at 0. A client MUST treat receipt of a push stream -with a Push ID that is greater than the maximum Push ID as a connection error of -type H3_ID_ERROR. +Each server push is identified by a unique Push ID, which is used to refer to +the push in various contexts throughout the lifetime of the connection. + +The Push ID space begins at zero, and ends at a maximum value set by the +MAX_PUSH_ID frame; see {{frame-max-push-id}}. Server push is only enabled on a +connection when a client sends a MAX_PUSH_ID frame. A client sends additional +MAX_PUSH_ID frames to control the number of pushes that a server can promise. A +server SHOULD use Push IDs sequentially. A client MUST treat receipt of a push I think both old and new are correct: which means there was a potential bug in the spec. Reasoning: my old reading was `server SHOULD start at 0 && use sequentially` but the new text seems slightly different. If the client and server disagree about how the ID space is used then there is the potential for interoperability problems. If a client thinks the first push ID is 0, then it can make assumptions about its accounting. If a server wants to send the first push ID as non-zero then there is no signal for it to ask for a credit window shift - it's just blocked. This seems to invalidate the statement that push is only enabled when MAX_PUSH_ID is sent. I'm wondering if MUST start at 0 makes sense here, even if that means a separate design issue. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3925#discussion_r458307067
- [quicwg/base-drafts] Rework flow of Push ID (#392… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Martin Thomson
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… ianswett
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop