Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)

[Dmitri Tikhonov <[e-mail]>]

dtikhonov commented on this pull request.



> @@ -149,7 +149,9 @@ peer's SETTINGS frame.
 
 Before a new entry is added to the dynamic table, entries are evicted from the
 end of the dynamic table until the size of the dynamic table is less than or
-equal to (maximum size - new entry size) or until the table is empty.
+equal to (maximum size - new entry size) or until the table is empty. The
+encoder MUST NOT evict a dynamic table entry unless it has first been

This is a much stricter limit than the one in the original proposal (#1644), which limits the number of unacked insertions to `MaxEntries`.  This restriction is used to prevent encoder from doing silly things.  I understand that we want this in, but I'd rather we did not put more than one change into a single commit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1763#pullrequestreview-159850829