Re: [quicwg/base-drafts] Allow servers to send a preferred address of each address family (#2296)

ianswett <notifications@github.com> Mon, 14 January 2019 18:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ABB6813120C for <quic-issues@ietfa.amsl.com>; Mon, 14 Jan 2019 10:53:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i7Rb9Uk8w2qE for <quic-issues@ietfa.amsl.com>; Mon, 14 Jan 2019 10:53:31 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 13A44126C7E for <quic-issues@ietf.org>; Mon, 14 Jan 2019 10:53:31 -0800 (PST)
Date: Mon, 14 Jan 2019 10:53:29 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547492009; bh=1TnVF4/uGg1SQnu9d1LjtjlsT9xw18mTyFA5jRtorZU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0uIndAf0rRFgE0RaLIULwbYdZB4SUGuO3QZbVhSQrak+EKSAcy0aVjUjuHVqhxFFo +WJl4s55mFPq9doUb04ZBCqzu7DrkcRDjGTKDAO+55Oz2tlrVZaJ+45Pv9epH0mk+4 f28orR2BG6dzGuLvwe5L3KdWdyUItpXk0fVcRHkU=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8662bf7c01cab682f214a1b922e720895ddb692a92cf0000000118549ca992a169ce179bec73@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2296/review/192306688@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2296@github.com>
References: <quicwg/base-drafts/pull/2296@github.com>
Subject: Re: [quicwg/base-drafts] Allow servers to send a preferred address of each address family (#2296)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3cdaa9bf66d_62003fac5a8d45b41325f0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/LCSCH1RxEMKcVhgp-Ofp6PZJZ1g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jan 2019 18:53:33 -0000

ianswett commented on this pull request.

Part of me wants to be more specific about what the preferred client behavior, but I realize you're being flexible intentionally, and I think that's ok in the end.

> @@ -2116,6 +2116,9 @@ packets.
 A server conveys a preferred address by including the preferred_address
 transport parameter in the TLS handshake.
 
+Servers MAY communicate a preferred address of each address family (IPv4 and

Re-reading this PR, I think its workable as is, but this might read better if this paragraph was merged into the next paragraph and the next paragraph was updated to something like: "one of the servers preferred addresses using..."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2296#pullrequestreview-192306688